Allow soft_delete instance which has never been active

[Yufang Zhang]

Since commit 99c51e34230394cadf0b82e364ea10c38e193979, instance is not able to be soft_deleted if instance has never been active. But there are circumstances when instance fails on initial build. Thus if we set reclaim_instance_interval in nova.conf, we cannot delete such instances in any way.

[Yufang Zhang (yufang521247)]

We can fix this problem by setting must_have_launched to 'Flase' when doing instance state check for soft_delete(). The instance can be deleted in _reclaim_queued_deletes() or force_delete() later.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37465

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37465
Committed: http://github.com/openstack/nova/commit/5b026e1a481b0e5790f06eaef3c8b593b43335cb
Submitter: Jenkins
Branch: master

commit 5b026e1a481b0e5790f06eaef3c8b593b43335cb
Author: Yufang Zhang <email address hidden>
Date: Wed Jul 17 21:26:30 2013 +0800

    Handle InstanceInvalidState of soft_delete

    Since commit 99c51e34230394cadf0b82e364ea10c38e193979, instance
    is not able to be soft_deleted if instance has never been active.
    But there are circumstances when instance fails on initial build.
    Thus if we set reclaim_instance_interval in nova.conf, we cannot
    delete such instances in any way.

    This patch fixes this by handling InstanceInvalidState exception
    when try to soft_delete instance. The delete() function is called
    for instance which has never been active.

    Bug 1202158

    Change-Id: I7d0d9414d7436e56b6a3e5861ee3c2f02473df2b