Nova API crashes for some special characters used in flavor ID

[Aswad Rangnekar]

Tested on: master with commit ID ddc20d70b38d18abb6e735d53c650873a7146770

If we create a flavor with ID as a special character with ascii character code >127,
an the entry is created in the database and it causes a 500 Internal Server Error while retrieving the flavors list,

Stack trace: http://paste.openstack.org/show/40662/

The issue here is that such characters as well as special symbols should not be allowed.
Flavor ID should be restricted to Integer values or UUID only, as enforced by python-novaclient.

[Sumanth Nagadavalli (sumanth-nagadavalli)]

Hi Aswad,

I tried reproducing this bug, but I got "400 malformed" in the response instead.

Please see the paste below,

http://paste.openstack.org/show/42580/

Nova API did not crash.

Could you test this again with the latest master and see if the bug still exists?

[Aswad Rangnekar (aswad-r)]

@sumanth-nagadavalli: Note that I have mentioned this bug is for special chars with ascii code>127,
you have provided asterix ( * ), which falls below that range.

[Rohit Karajgi (rohitk)]

I am able to reproduce this issue on the latest nova code.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39441
Committed: http://github.com/openstack/nova/commit/578b76a55fc41b1380b18b3ade78b91677f5381b
Submitter: Jenkins
Branch: master

commit 578b76a55fc41b1380b18b3ade78b91677f5381b
Author: Rohan Kanade <email address hidden>
Date: Thu Jul 25 06:26:26 2013 -0700

    Adds Flavor ID validations

    * Flavor ID should not contain special symbols.
    * Flavor ID should be in range 1-255 characters.
    * Flavor ID should not have leading/trailing whitespaces.

    Fixes LP Bug 1202136
    DOCIMPACT

    Change-Id: I63c36811a57982e826f22f827f86d40ff6a6210e