Live migration on XenAPI is not live when using pools

[Vangelis Tasoulas]

Live migration on XenAPI is not live.

In short, this fixes the problem for me:

--- nova-orig/virt/xenapi/vmops.py 2013-07-15 14:21:05.532868954 +0200
+++ nova/virt/xenapi/vmops.py 2013-07-16 14:54:10.865301101 +0200
@@ -1727,7 +1727,7 @@
                 host_ref = self._get_host_opaque_ref(context,
                                                      destination_hostname)
                 self._session.call_xenapi("VM.pool_migrate", vm_ref,
- host_ref, {})
+ host_ref, { "live": "true" })
             post_method(context, instance, destination_hostname,
                         block_migration)
         except Exception:

For more information, look at the following question:
https://answers.launchpad.net/nova/+question/232484

[John Garbutt (johngarbutt)]

This is on the pool live-migrate case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37666
Committed: http://github.com/openstack/nova/commit/01f2f46d64bb81256cb06a8e8a091e6f5fabedc8
Submitter: Jenkins
Branch: master

commit 01f2f46d64bb81256cb06a8e8a091e6f5fabedc8
Author: John Garbutt <email address hidden>
Date: Thu Jul 18 12:46:59 2013 +0100

    xenapi: ensure pool based migrate is live

    The current code is missing a flag to pool_migrate that should be
    included to ensure the migrate is live. This change adds that flag to
    both uses of VM.pool_migrate, namely the live-migrate call and the
    host_maintenance call.

    Fixes bug 1201795
    Change-Id: I265baaba5e9bd9132bd5e1c6f9fb18cefab02cfb