[objects] Changes to system_metadata aren't saved
Bug #1201776 reported by
Michael Still
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Dan Smith | ||
Bug Description
I need to talk to Dan and Chris about this, but it looks to me like changes to system_metadata aren't tracked in Instance objects. They're therefore not saved when you call save().
| Changed in nova: | |
| assignee: | nobody → Dan Smith (danms) |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → havana-3 |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | havana-3 → 2013.2 |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit 7a20e5581f7b33b
Author: Dan Smith <email address hidden>
Date: Mon Jul 15 13:44:55 2013 -0700
Make Instance object properly update *metadata
Currently, the Instance object won't notice when metadata or
system_metadata has changed and thus won't include it in updates it
makes to the database.
We could make these two dicts full-fledged objects, but that's a bit
overkill for this purpose. Stash a copy of them every time we reset
our changes so that we can detect changes in save().
Note that this includes tests to some shelve tests which are now
wrong because they modify the instance's sys_meta prematurely.
Turns out, these are the tests that pointed out the need for
this tracking :)
Related to blueprint unified-
Fixes bug 1201776
Change-Id: I3df46264597974