Argument mismatch between l3_rpc_agent_api.py and l3-agent

Bug #1201553 reported by Nachi Ueno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Mark McClain

Bug Description

There are augment mismatch between l3_rpc_agent_api.py and l3-agent

L3-agent side uses router_ids and fullsync
https://github.com/openstack/neutron/blob/master/neutron/agent/l3_agent.py#L73

Server side uses router_id
https://github.com/openstack/neutron/blob/master/neutron/db/l3_rpc_base.py#L40 using router_id

Akihiro Motoki (amotoki)
summary: - Augment mismatch betwen l3_rpc_agent_api.py and l3-agent
+ Argument mismatch betwen l3_rpc_agent_api.py and l3-agent
Akihiro Motoki (amotoki)
Changed in neutron:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/37193

Changed in neutron:
status: New → In Progress
Nachi Ueno (nati-ueno)
Changed in neutron:
importance: Undecided → High
summary: - Argument mismatch betwen l3_rpc_agent_api.py and l3-agent
+ Argument mismatch between l3_rpc_agent_api.py and l3-agent
Changed in neutron:
milestone: none → havana-2
Changed in neutron:
assignee: Akihiro Motoki (amotoki) → Mark McClain (markmcclain)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/37193
Committed: http://github.com/openstack/neutron/commit/de1967452e935e8d78255c448715a588d19ae838
Submitter: Jenkins
Branch: master

commit de1967452e935e8d78255c448715a588d19ae838
Author: Akihiro MOTOKI <email address hidden>
Date: Tue Jul 16 17:05:19 2013 +0900

    Fix argument name mismatch in L3-RPC sync_routers

    In sync_routers L3-RPC method l3-agent sends router_ids but the
    server side expected router_id. This commit fixes the server side
    to accept router_ids, and drops "fullsync" arg from the agent side
    (fullsync is not used anywhere and it does not affect RPC signature).
    This change allows l3-agent to sync only the specified routers
    instead of all routers.

    Fixes bug #1201553

    As a result of the above change, auto_schedule_routers() and
    list_active_sync_routers_on_active_l3_agent() in L3 scheduler
    needs to handle a list of router IDs. This commit changes L3 scheduler
    to accept a list of router IDs in the above two methods.

    Also fixes the argument order of fullsync and router_ids in get_routers
    in L3PluginApi. L3-agent main code expects router_ids as the second arg.

    Change-Id: I22e8d11b9676cbcfe9e72449031bb63071be8314

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.