_retrieve_extra_groups in Nicira plugin incompatible with oslo.config >= 1.2.0

[Dirk Mueller]

./quantum/plugins/nicira/nicira_nvp_plugin/common/config.py includes this code:

def _retrieve_extra_groups(conf, key=None, delimiter=':'):
    """retrieve configuration groups not listed above."""
    results = []
    for parsed_file in cfg.CONF._cparser.parsed:
        for parsed_item in parsed_file.keys():
            if parsed_item not in cfg.CONF:
                items = key and parsed_item.split(delimiter)
                if not key or key == items[0]:
                    results.append(parsed_item)
    return results

Recently, _cparser has been renamed/removed as the implementation in oslo.config was changed by Mark. since then this code fails.

The code needs to be adopted in order to handle newer oslo.config versions. See bug 1196084 for details.

[Dirk Mueller (dmllr)]

(this is for Grizzly branch only, dunno how to tag it properly)

[Salvatore Orlando (salvatore-orlando)]

Thanks for reporting this.
I don't know either how to specify a file affect only the stable branch.

[Armando Migliaccio (armando-migliaccio)]

This bug is invalid as far as Havana goes, as the code has been removed. I'll get it addressed for the stable branch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/40940

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/40940
Committed: http://github.com/openstack/neutron/commit/a63072a9cfc2434253846eb2e6d43d157a693fc2
Submitter: Jenkins
Branch: stable/grizzly

commit a63072a9cfc2434253846eb2e6d43d157a693fc2
Author: armando-migliaccio <email address hidden>
Date: Thu Aug 8 11:14:41 2013 -0700

    Address config incompatibility introduced with oslo.config >= 1.2.0

    This patch changes how nvp cluster specific configuration is retrieved
    from nvp.ini so that it no longer relies on _cparser, which has been
    removed in newer versions of oslo.config.

    Fixes bug #1200609

    Change-Id: I631c6584ca6b45d0f716533bd1d711d049c6f157