timeutils.utcnow() should be used throughout the code instead of datetime.datetime.utcnow()

Bug #1200141 reported by Roman Podoliaka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Roman Podoliaka

Bug Description

timeutils.utcnow() should be used instead of direct calls to datetime.datetime.utcnow() to make it easy to override its return value in tests.

Tags: tests
Changed in nova:
assignee: nobody → Roman Podolyaka (rpodolyaka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/36662

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/36662
Committed: http://github.com/openstack/nova/commit/2e83be17d101c1501795708a9acc4671dee9c02d
Submitter: Jenkins
Branch: master

commit 2e83be17d101c1501795708a9acc4671dee9c02d
Author: Roman Podolyaka <email address hidden>
Date: Thu Jul 11 11:52:52 2013 +0300

    Use timeutils.utcnow() throughout the code

    timeutils.utcnow() should be used instead of direct calls to
    datetime.datetime.utcnow() to make it easy to override its return
    value in tests.

    Add a hacking rule to prevent regressions.

    Fixes bug 1200141.

    Change-Id: I170dbd7c9093bd627e2a0d5984b7ad1bf105c8d5

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.