API check for valid states to allow detaching from is wrong

[Duncan Thomas]

volume.api.check_detach currently does:
    if volume['status'] == "available":
        raise exception.ApiError(_("Volume is already detached"))
..and otehrwise allows the detach to proceed.

This means that if the volume is in attaching, then the detach proceeds. If the compute side detach does an eventlet yield, then the detach can happen while the attach is mid way through doing an attach, which can result in badness.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/36522

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/36522
Committed: http://github.com/openstack/cinder/commit/cfe8dc42254e6f808bec61f89ea4a43504704000
Submitter: Jenkins
Branch: master

commit cfe8dc42254e6f808bec61f89ea4a43504704000
Author: Duncan Thomas <email address hidden>
Date: Wed Jul 10 19:28:39 2013 +0100

    Change check-detach to reject more states

    Change check_detach is reject anything other than 'in-use', rather than
    just rejecting 'available'.

    Fixes bug #1199922

    Change-Id: I3180540ca7bb699a3494ca4eea1389ae8a117df0