xenapi: glance upload retries should not occur on 401 errors

[John Garbutt]

When the user's token expires, you might get this error during the upload of the glance image from the XenAPI plugin:

glance: ERROR Unexpected response while writing image data to http://X.X.X.X/v1/images/<uuid>: Response Status: 401, Response body: 401 Unauthorized This server could not verify that you are authorized to access the document you requested. Either you supplied the wrong credentials (e.g., bad password), or your browser does not understand how to supply the credentials required. Authentication required

It seems pointless to retry in these cases without making an error to refresh a token, or similar.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/36308

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/36308
Committed: http://github.com/openstack/nova/commit/8e81e069a18e09562abfc4b18c5c7e57020aee66
Submitter: Jenkins
Branch: master

commit 8e81e069a18e09562abfc4b18c5c7e57020aee66
Author: John Garbutt <email address hidden>
Date: Tue Jul 9 18:49:46 2013 +0100

    xenapi: no glance upload retry on 401 error

    It is possible for a token to expire during a very long image upload.
    If this happens, there is little point in retrying the upload, as it
    is most likely to fail again for the same reason.

    Fixes bug 1199454

    Change-Id: Id699135a8ec4c603671b16f0127d0b2cd2a55855