build/depends.py hardcodes the library path on UNIX

Bug #1198916 reported by Aurélien Bompard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
Unassigned

Bug Description

In the build/depends.py file, the path to library files in UNIX is set in the UNIX_LIB_PATH variable. But this path hardcodes "lib" as the library directory, which is wrong on 64bit architectures (it's lib64).
The attached patch adds a test to fix this.

Revision history for this message
Aurélien Bompard (abompard) wrote :
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Aurélien,

Thank you for your patch, It looks reasonable.
Can you explain the failure without the patch and how to check that it is fixed?

Thank you,

Daniel

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 1198916] Re: build/depends.py hardcodes the library path on UNIX

Hi Aurélien,

Thank you for the patch. Unfortunately it is not general since lib64 is
just a convention. It will not work for all distros because some distros do
not use lib64 on 64-bit.

Instead, we should just make the libdir configurable from the commandline
rather than hard-coded. Distros that use lib64 will need to specify the
libdir via the scons command.

Best regards,
RJ Ryan

On Mon, Jul 8, 2013 at 4:08 PM, Daniel Schürmann <<email address hidden>
> wrote:

> Hi Aurélien,
>
> Thank you for your patch, It looks reasonable.
> Can you explain the failure without the patch and how to check that it is
> fixed?
>
> Thank you,
>
> Daniel
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1198916
>
> Title:
> build/depends.py hardcodes the library path on UNIX
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1198916/+subscriptions
>

Revision history for this message
Aurélien Bompard (abompard) wrote :

OK, I thought all 64 bits distro used lib64, if not then I agree rryan's solution is best.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

We now support LIBDIR!

Changed in mixxx:
status: New → Fix Released
milestone: none → 1.12.0
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7101

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.