Avoid ImportError on selenium

Bug #1197815 reported by Sascha Peilicke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Sascha Peilicke

Bug Description

Several distribution can't ship selenium due to it's non-free license. So they have to patch it out of test-requirements.txt. Instead of having to also patch out all selenium-related tests, it's easier to improve WITH_SELENIUM by avoiding an import failure and force not running selenium tests.

Changed in horizon:
assignee: nobody → Sascha Peilicke (saschpe)
status: New → In Progress
Revision history for this message
Sascha Peilicke (saschpe) wrote :

Selenium isn't part of most OSS distributions because it ships binaries which can't be easily built from source. Here are some reference bugs:

openSUSE:
https://bugzilla.novell.com/show_bug.cgi?id=755619

Debian:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700061

Revision history for this message
Julie Pichon (jpichon) wrote :

Thanks for the summary Sascha.

Link to the mailing list discussion: http://lists.openstack.org/pipermail/openstack-dev/2013-July/011377.html

Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/35649
Committed: http://github.com/openstack/horizon/commit/19d62d56172374571fccfe3f1dbb5f052c14ce35
Submitter: Jenkins
Branch: master

commit 19d62d56172374571fccfe3f1dbb5f052c14ce35
Author: Sascha Peilicke <email address hidden>
Date: Thu Jul 4 15:18:21 2013 +0200

    Avoid ImportError when selenium is missing.

    Also provide a warning message. Fixes LP bug 1197815

    Change-Id: Id7ffaa8820eefd216d2258d56736a65ddb2483c2

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.