Message about signing dir ownership can cause backtrace

Bug #1197755 reported by Donagh McCabe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Donagh McCabe

Bug Description

This was mentioned in Bug #1180998, but probably overlooked, so I'm creating it's own bug report.

When starting Swift as sudo, I frequently get a failure of this test in auth_token.py:

    if os.stat(self.signing_dirname).st_uid != os.getuid():

(even though the directory is owned by swift)

However, the message logged uses this code:

    LOG.warning(
        'signing_dir is not owned by %s' % os.getlogin())

Notice, os.getlogin() -- not os.getiod() -- is called. This fails with a permission denied; instead of logging a message, the proxy-server is killed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/35634

Changed in python-keystoneclient:
assignee: nobody → Donagh McCabe (donagh-mccabe)
status: New → In Progress
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/35634
Committed: http://github.com/openstack/python-keystoneclient/commit/fca985c09e11c581b61b9edcae19673e3112093a
Submitter: Jenkins
Branch: master

commit fca985c09e11c581b61b9edcae19673e3112093a
Author: Donagh McCabe <email address hidden>
Date: Thu Jul 4 11:47:33 2013 +0100

    Fix auth_token.py bad signing_dir log message

    Fixes bug 1197755

    Change-Id: I16152518c354821af6790a6e459f1d8ec09139a0

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.3.2
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.