no support for two factor authentication
Bug #1197081 reported by
Mike McCracken
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntuone-credentials |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntuone-credentials (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
the 2fa code is always being set to NULL, and is currently not exposed to API users
Related branches
lp:~mikemc/ubuntuone-credentials/add-2fa
- dobey (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 494 lines (+167/-47)13 files modifiedlibubuntuoneauth/identityprovider.cpp (+11/-4)
libubuntuoneauth/identityprovider.h (+1/-0)
libubuntuoneauth/requests.cpp (+0/-1)
libubuntuoneauth/ssoservice.cpp (+11/-3)
libubuntuoneauth/ssoservice.h (+3/-1)
music-login/ssowizard.cpp (+9/-0)
music-login/ssowizard.h (+1/-0)
qml-credentials-service/CredentialsUI.qml (+51/-17)
qml-credentials-service/LoginForm.qml (+11/-16)
qml-credentials-service/RegisterForm.qml (+1/-1)
qml-credentials-service/TwoFactorForm.qml (+55/-0)
qml-credentials-service/ubuntuone_credentials_service.cpp (+10/-3)
qml-credentials-service/ubuntuone_credentials_service.h (+3/-1)
tags: | added: u1-notrack |
Changed in ubuntuone-credentials: | |
status: | New → Fix Committed |
Changed in ubuntuone-credentials: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntuone- credentials - 14.04+14. 04.20140306
--------------- credentials (14.04+ 14.04.20140306) trusty; urgency=low
ubuntuone-
[ Diego Sarmentero ]
* adding files
* ssolib files
* adding license
* SSO Lib working
* new folder structure
* updating .pro
* Fixing some design issues.
* Improve Error handling in the application as requested by design.
* Support urls in the --picture argument, to handle download of the
image from this application.
* Fix UI flow requested by design for Returning Customers.
[ Leo Arias ]
* Cleaned the autopilot tests.
* Refactor the fake servers to be a thread on the same process,
started from a fixture on the test setup.
* Added missing files from previous autopilot fixtures MP. .
[ Ubuntu daily release ]
* New rebuild forced
[ CI bot ]
* No change rebuild against Qt 5.2.1.
[ Brian Curtin ]
* Update the tests.pro file to work with changes to how the library is
built.
* Add more tests.
[ Michael McCracken ] eauth to access creds and sign API requests.
* Simplify header layout to avoid issues in packaging. (LP: #1190782).
(LP: #1190782)
* Improvements to available slots and signals on ssoservice object.
* Fixes for registration
* mark two methods of Token as const, and fix a leak from oauth
library.
* Add QML plugin that wraps login/register and signUrl functionality
of libubuntuoneauth, and accompanying QML UI prototype
* Add support for two-factor auth to the ssoservice and QML plugin
(LP: #1197081). (LP: #1197081)
* Add error signal for failure cases in Network class - covers
connection failures.
* Improve UI, better support embedding into external QML, and add
embedding example code.
* Fix credential deletion and expose it via QML plugin.
* Validate input and show error messages for invalid email, short
password, etc.
* add cmake rule to generate qmltypes file for qtcreator integration.
* Make background of embeddable component transparent, and use smaller
font sizes to fit better on small screens.
* Fix typo in signal connection for handleError.
* set signon plugin name to 'ubuntuoneplugin' as required by the
signond plugin loader.
* Ensure initial value of _state variable is IDLE.
* Add UOA provider plug-in to house login/register UI. Move that UI
from credentials service plug-in.
* Fix example code for QML plugin to no longer try to show the
CredentialsUI that doesn't exist anymore, and improve its comments
to better explain the remaining API.
* Re-add a regexp validator to the email textfield.
* Add minimal Qt/C++ example app and README describing how to use
libubuntuon
* Add cancel/continue buttons back.
* Fix spacing and margins of login/register UI. Use default fontSizes
pending design input.
* Provide faster visual feedback of activity after clicking
'continue'.
* Fix flickable scrolling. Fix sizing of nested Columns in LoginForm
and RegisterForm, and use correct anchors.
* Improve integration with Online Accounts System settings module.
* Fix registration errors caused by scrambling parameters due ...