image_tag_get_all only returns not found for non-existant image in simple db

Bug #1197057 reported by Alex Meade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Alex Meade

Bug Description

image_tag_get_all in simple db will raise a NotFound error if the given image does not exist. In sqlalchemy driver however, it will just return an empty list.

Both database drivers should have the same result in this case.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/35412

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/35412
Committed: http://github.com/openstack/glance/commit/dc5112f794c6da796cc2a64c61a159ab6a3af671
Submitter: Jenkins
Branch: master

commit dc5112f794c6da796cc2a64c61a159ab6a3af671
Author: Alex Meade <email address hidden>
Date: Tue Jul 2 19:04:18 2013 -0400

    Dont raise NotFound in simple db image_tag_get_all

    This patch removes the check in simple db. This is so both simple db and
    sqlalchemy have the same behavior. We do not necessarily want to perform two
    queries to see if the image exists so an empty list of tags is returned.

    Fixes bug 1197057

    Change-Id: Ibae37198b3854aa5dbe0e8a643a3d4b8608666c5

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.