insert image fails from "recently used" file list

Bug #1195759 reported by kurty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
RedNotebook
Fix Released
Medium
Jendrik Seipp

Bug Description

Method:
-Open insert image dialogue.
-Choose "recently used" places on left sidebar in dialogue.
-Choose file.
-Click "Open" button in lower right corner of dialogue.
-Dialogue exits but not link or text of any kind is inserted.

-Following same procedure but going directly to file (eg ~/Pictures/picture.png) produces proper result.

This is also the case for the insert file dialogue.

Linux Mint 15 Cinnamon.
Rednotebook 1.7.1

Related branches

Revision history for this message
kurty (kurt-schreiter) wrote :
Revision history for this message
Jendrik Seipp (jendrikseipp) wrote :

Thanks for reporting this, I fixed it now for the next version.

Changed in rednotebook:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Jendrik Seipp (jendrikseipp)
Revision history for this message
kurty (kurt-schreiter) wrote : Re: [Bug 1195759] Re: insert image fails from "recently used" file list

Wow, that was fast!
Thanks,
Kurt
--
Kurt Schreiter, MSc
Vanier Scholar, Graduate Student (PhD)
Department of Physics and Astronomy
University of Waterloo
200 University Avenue West
Waterloo, Ontario
N2L 3G1 Canada

On Fri, Jun 28, 2013 at 12:16 PM, Jendrik Seipp <email address hidden> wrote:

> Thanks for reporting this, I fixed it now for the next version.
>
> ** Changed in: rednotebook
> Status: New => Fix Committed
>
> ** Changed in: rednotebook
> Importance: Undecided => Medium
>
> ** Changed in: rednotebook
> Assignee: (unassigned) => Jendrik Seipp (jendrikseipp)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1195759
>
> Title:
> insert image fails from "recently used" file list
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/rednotebook/+bug/1195759/+subscriptions
>

Changed in rednotebook:
status: Fix Committed → Fix Released
Revision history for this message
Daniel Seifert (dseifert) wrote :

The fix (commit 1298) breaks the use of opening the file chooser in the last used directory for inserting an image.

For the image file chooser, dirs.last_pic_dir is used for set_current_folder (insert_menu.py line 171). However this variable is not set anymore after commit 1298 (now dirs.last_file_dir is used, probably as it was copied from the on_insert_file function?).

Revision history for this message
Jendrik Seipp (jendrikseipp) wrote :

Thanks for fixing this, I just applied your patch.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.