Incorrect use of get_gateway retval in DeviceManager

Bug #1195543 reported by Carl Baldwin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Carl Baldwin

Bug Description

My patch to #1181378 did not properly handle the return value from get_gateway. I'll fix it with a patch coming right up.

Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

This bug is not terribly urgent. The code in DeviceManager still works but it ends up calling add_gateway more often than necessary.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34833

Changed in neutron:
assignee: nobody → Carl Baldwin (carl-baldwin)
status: New → In Progress
Akihiro Motoki (amotoki)
description: updated
Changed in neutron:
importance: Undecided → Medium
milestone: none → havana-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/34833
Committed: http://github.com/openstack/quantum/commit/21fd100a98c152086193607cd311c2ee03b82643
Submitter: Jenkins
Branch: master

commit 21fd100a98c152086193607cd311c2ee03b82643
Author: Carl Baldwin <email address hidden>
Date: Fri Jun 28 03:07:00 2013 +0000

    Update code to properly use dict returned from get_gateway.

    Calling get_gateway was a late addition to my code to add a default
    route in the DHCP namespace. The code did not properly handle the
    dict returned from that method. This changes it to properly extract
    the 'gateway' attribute from the dict.

    Change-Id: I9823a31feee7ab333c277fc6e78f366408393155
    Fixes: Bug #1195543

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.