Shall provide a way to register implicit conf options for generate_sample.sh

Bug #1195538 reported by xingzhou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Julien Danjou

Bug Description

etc/ceilometer.conf.sample is generated by tools/conf/generate_sample.sh which will call ceilometer/openstack/common/config/generator.py. While generator.py will scan the ceilometer modules and write sample conf option enties if the module has global cfg.Opt attribute. But for some modules like storage, the conf option is located in corresponding engine class and will be registered when get_connection is called. This will prevent such conf options generated in ceilometer.conf.sample.

I would like to suggest we implement a new approach to let generator.py know what shall be written into the sample conf file.

Revision history for this message
Julien Danjou (jdanjou) wrote :

It shall be simpler to always register storage options globally.

Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Triaged
importance: Undecided → Low
Julien Danjou (jdanjou)
Changed in ceilometer:
assignee: nobody → Julien Danjou (jdanjou)
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/37492

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/37492
Committed: http://github.com/openstack/ceilometer/commit/5345f4f8016ffb81678c821e9adf03a12657425f
Submitter: Jenkins
Branch: master

commit 5345f4f8016ffb81678c821e9adf03a12657425f
Author: Julien Danjou <email address hidden>
Date: Wed Jul 17 16:47:27 2013 +0200

    storage: remove per-driver options

    Fixes: bug #1195538

    Change-Id: Iac6ace9a2402237543ed35be7f4fcee91ff3e036
    Signed-off-by: Julien Danjou <email address hidden>

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.