Bug #1194608 “Safely remove does not work (LED is on) on USB 3.0...” : Bugs : udisks package : Ubuntu

Revision history for this message

Norbert (nrbrtx) wrote on 2013-06-25:

#1

AtaSmartBlob_sda.gz Edit (593 bytes, application/x-gzip)
BootDmesg.txt Edit (190.2 KiB, text/plain; charset="utf-8")
CurrentDmesg.txt Edit (245.5 KiB, text/plain; charset="utf-8")
Dependencies.txt Edit (2.3 KiB, text/plain; charset="utf-8")
Lspci.txt Edit (23.1 KiB, text/plain; charset="utf-8")
Lsusb.txt Edit (697 bytes, text/plain; charset="utf-8")
Mounts.txt Edit (1.7 KiB, text/plain; charset="utf-8")
ProcCpuinfo.txt Edit (6.6 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (297 bytes, text/plain; charset="utf-8")
ProcInterrupts.txt Edit (4.5 KiB, text/plain; charset="utf-8")
ProcModules.txt Edit (5.5 KiB, text/plain; charset="utf-8")
UDisksDump.txt Edit (25.3 KiB, text/plain; charset="utf-8")
UdevDb.txt Edit (167.5 KiB, text/plain; charset="utf-8")
UdevLog.txt Edit (354.9 KiB, text/plain; charset="utf-8")

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2013-11-19:

#5

I have Ubuntu 12.04.3 with GNOME 3.4 and udisks 1.0.4-5ubuntu2.1. With this software I can do a Safely remove of a USB-flash or external USB-HDD from nautilus (3.4.2-0ubuntu8) and from gnome-disk-utility (3.0.2-2ubuntu7).

In modern linux distros (such as Ubuntu 13.04, 13.10, Mageia 4, Fedora 19, OpenSuse 12.3) there is no Safely remove option in Nautilus (see https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1067876 and https://bugs.freedesktop.org/show_bug.cgi?id=60293).

In gnome-disks Safely remove / Poweroff is appeared again (from 3.8, see https://bugzilla.gnome.org/show_bug.cgi?id=675542), but it does not spin-down external USB-HDD.

In some linux distros I can spin-down my disk with "udisks --detach /dev/sdX", but it is not user-friendly.

So please, enable spin-down on the udisks side.

I understand that external SATA (and IDE) HDDs are hot-pluggable and hot-swappable, but it is not comfortable for me to detach rotating drive.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2013-12-24:

#6

Bug exists in Fedora 20 with gnome-disk-utility 3.10.0
UDisks 2.1.1 (built against 2.1.1).

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2013-12-24:

#7

There is no Safely remove option in Nautilus 3.10.1 too.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-01-18:

#8

Tested again on Arch with
* gnome-disk-utility 3.10.0 UDisks 2.1.1 (built against 2.1.1)
* Nautilus 3.10.1

- the bug exists with both applications. Please fix it.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-01-20:

#9

The reason that

$ udisks --detach /dev/sdX

spins down the disk properly but clicking the "Power off" menu item in the GNOME Disks application doesn't has to do with the fact that the udisks program is from udisks version 1 and was rewritten in udisks version 2.

udisks v1: http://cgit.freedesktop.org/udisks/tree/src/helpers/job-drive-detach.c?id=1.0.4

udisks v2: http://cgit.freedesktop.org/udisks/tree/src/udiskslinuxdrive.c?id=2.1.2#n1195

As you can see, both v1 and v2 does this by writing a '1' to the 'remove' sysfs attribute on the parent USB device, as per

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=253e05724f9230910344357b1142ad8642ff9f5a

and this makes most USB-attached disk drives actually power down - at least all the different devices that I've tested with.

However, what's missing in v2 (and present in v1) is the following steps

1. sending the SCSI SYNCHRONIZE CACHE command
2. sending START/STOP UNIT command
3. unbinding the USB Mass Storage kernel driver

Notably, there's actually a TODO item in v2 for doing this:

/* TODO: Send the eject? Send SCSI START STOP UNIT? */

Now, I don't think that 3. is necessary as it happens as part of writing to the 'remove' sysfs file. That leaves 1. and 2.

Here's what I'd like to you try. Does

sg_start --stop /dev/sdX

do what you want? If so, we should add 1. and 2. to v2.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-01-21:

#10

Dear David!
First of all I would like to thank you for answer and recommendation!

I tested my USB-harddrives with sg_start utility. Thank you for hint, I did not know about SCSI utilities before.

I made such tests under Ubuntu 12.04.4, Fedora 20 and OpenSuSe 13.1 with all installed updates.
* Ubuntu 12.04.4 does not have udisks2, it has udisks 1.0.4-5ubuntu2.1, sg3-utils 1.33-1.
* Fedora 20 has udisks-1.0.4-12.fc20.i686, udisks2-2.1.2-1.fc20.i686, sg3_utils-1.37-2.fc20.i686.
* OpenSuSe 13.1 has udisks-1.0.4-13.1.3.i586, udisks2-2.1.1-2.1.3.i586, sg3_utils-1.36-3.1.2.i586.

For more adequate results I disabled auto-mount feature in GNOME with dconf-editor (as recommended here - https://help.ubuntu.com/community/Mount/USB#Configuring_Automounting).

My test results are the following:
1. For my USB-HDD (Seagate ST9750420A in USB 2.0 Tsunami e-data 2500 enclosure,
  lsusb - 04fc:0c25 Sunplus Technology Co., Ltd SATALink SPIF225A)
    1.1. command “sg_start --stop /dev/sdX” really spin-downs my drive (sometimes on 2nd or 3rd attempt - I don’t know why), device remains in system and spin-up again only on my demand.
    1.2. command “udisks --detach /dev/sdX” spin-downs my drive (always on 1st attempt), device is completely removed from system after detach.

2. For my USB 3.0 WD My Passport Ultra (WD WD20NMVW,
  lsusb - 1058:0743 Western Digital Technologies, Inc.)
    2.1. command “sg_start --stop /dev/sdX” is ignored by this HDD (it make one click, but does not spin-down). Maybe it is because of proprietary/non-fully-compliant ATA-command set in WD’s controller.
    2.2. command “udisks --detach /dev/sdX” spin-downs my drive (on 1st attempt always), device is completely removed from system after detach.

So the results are identical for all three distros.
For me it seems, that “udisks --detach” works better and in 100% (on all distros and with proprietary WD HDD-controller).
So if you have time, please, do deeper comparison between udisks v.1, udisks v.2 and sg_start.

I'm ready to do more testing if you send me concrete instruction, but I am not expert and I do not know how to debug/trace/log ATA and udisks.

Dear David!
First of all I would like to thank you for answer and recommendation!

I tested my USB-harddrives with sg_start utility. Thank you for hint, I did not know about SCSI utilities before.

I made such tests under Ubuntu 12.04.4, Fedora 20 and OpenSuSe 13.1 with all installed updates.
* Ubuntu 12.04.4 does not have udisks2, it has udisks 1.0.4-5ubuntu2.1, sg3-utils 1.33-1.
* Fedora 20 has udisks-1.0.4-12.fc20.i686, udisks2-2.1.2-1.fc20.i686, sg3_utils-1.37-2.fc20.i686.
* OpenSuSe 13.1 has udisks-1.0.4-13.1.3.i586, udisks2-2.1.1-2.1.3.i586, sg3_utils-1.36-3.1.2.i586.

For more adequate results I disabled auto-mount feature in GNOME with dconf-editor (as recommended here - https://help.ubuntu.com/community/Mount/USB#Configuring_Automounting).

My test results are the following:
1. For my USB-HDD (Seagate ST9750420A in USB 2.0 Tsunami e-data 2500 enclosure, 
  lsusb - 04fc:0c25 Sunplus Technology Co., Ltd SATALink SPIF225A)
    1.1. command “sg_start --stop /dev/sdX” really spin-downs my drive (sometimes on 2nd or 3rd attempt - I don’t know why), device remains in system and spin-up again only on my demand.
    1.2. command “udisks --detach /dev/sdX” spin-downs my drive (always on 1st attempt), device is completely removed from system after detach.

2. For my USB 3.0 WD My Passport Ultra (WD WD20NMVW,
  lsusb - 1058:0743 Western Digital Technologies, Inc.)
    2.1. command “sg_start --stop /dev/sdX” is ignored by this HDD (it make one click, but does not spin-down). Maybe it is because of proprietary/non-fully-compliant ATA-command set in WD’s controller.
    2.2. command “udisks --detach /dev/sdX” spin-downs my drive (on 1st attempt always), device is completely removed from system after detach.

So the results are identical for all three distros.
For me it seems, that “udisks --detach” works better and in 100% (on all distros and with proprietary WD HDD-controller).
So if you have time, please, do deeper comparison between udisks v.1, udisks v.2 and sg_start.

I'm ready to do more testing if you send me concrete instruction, but I am not expert and I do not know how to debug/trace/log ATA and udisks.

Revision history for this message

In freedesktop.org Bugzilla #71802, programmist11180 (programmer11180) wrote on 2014-01-21:

#11

Debian, udisks2 v 2.1.2-1. When I do safely remove of Seagate Portable from Thunar, udisks2 doesn't switch off a disk power when detaching. But udisks1 switch off a disk power.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-01-25:

#12

Thanks for testing. I'll look into making udisks2 sending SYNCHRONIZE CACHE and START/STOP UNIT commands. Stay tuned.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-01-26:

#13

OK, I just made that change

http://cgit.freedesktop.org/udisks/commit/?id=fcdd8f48b6ac9b1b6da82fdf5f59230fc2ea6feb

and tested it with a couple of different units. Notes

- One of my devices (bus-powered) does not accept the START STOP UNIT
command so we just continue if it fails. That is, this patch should
not break existing behavior.

- Another device (not bus-powered) used to spin down a couple of seconds
after removing power to the USB port. With this patch it spins down
immediately. (Which is actually nicer.)

- Still works on USB sticks etc.

- I didn't add SCSI SYNCHRONIZE CACHE as that command failed on all my
   devices. I also don't think it's necessary as the device drivers will
   issue something like this in part of the fsync(2) call that we do
   before this.

Please test if the patch works and report back - thanks!

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-01-26:

#14

> command “sg_start --stop /dev/sdX” really spin-downs my drive (sometimes
> on 2nd or 3rd attempt - I don’t know why), device remains in system and
> spin-up again only on my demand.

Btw, this is because the sg_start command opens the device node with O_RDWR which causes an uevent 'change' event to fire when the command completes. This in turn causes udev rules to fire which accesses the disk which causes it to spin up again. In the patch I committed to udisks to do this, we use O_RDONLY to avoid this.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-02:

#15

Thank you for your commits, David!

I installed all build-dependencies on my Ubuntu 14.04 system with 'apt-get install build-dep', did a 'git clone git://anongit.freedesktop.org/udisks', did './autogen.sh', did 'make', did 'sudo checkinstall make install', verified that I have udisks 2.1.3 installed with 'apt-cache policy', did 'mv /usr/local/share/polkit-1/actions/org.freedesktop.udisks2.policy /usr/share/polkit-1/actions/' and rebooted my machine.

Please note: automount is disabled.
What I get after reboot?

1. for USB-HDDs (both drives have EXT4 and NTFS partitions)
1.1. Seagate - 'Safely remove drive' option in Nautilus spinned-down it, gnome-disks spinned-down it after click on 'Power off the drive'. The 'udisksctl power-off -b /dev/sdX' works too.
If I enable automount, the 'Safely remove drive'/'Power off the drive' spins-down my drive. It's very good!

1.2. WD - 'Safely remove drive' option in Nautilus spinned-down it, gnome-disks 'Power off the drive' and 'udisksctl power-off -b /dev/sdX' works too.
But there is a little difference - if I enable automount the 'Safely remove drive'/'Power off the drive' does not spin-down the disk (disk plates rotating, but device is removed from system), I reopen the bug because of this.

2. for USB-flashes
There is no 'Safely remove drive' option in Nautilus for my USB-flashes. After 'Eject' the parent device remains in system and may be powered-off by gnome-disks. For me it's a good compromise between udisks1 and udisks2 behavior.

I'm ready to test and collect logs of my WD USB-HDD. I can't understand why Seagate drive unmounts all partitions before power-off, but WD does not.
What logs can help you to understand the problem?

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-02-03:

#16

Hey, thanks for testing the patches.

(In reply to comment #10)
> 1.2. WD - 'Safely remove drive' option in Nautilus spinned-down it,
> gnome-disks 'Power off the drive' and 'udisksctl power-off -b /dev/sdX'
> works too.
> But there is a little difference - if I enable automount

I have an idea of what's wrong here but before I speculate on that, what exactly does "enable automount" mean? Are you referring to having the 'auto' option in the /etc/fstab file?

> the 'Safely remove
> drive'/'Power off the drive' does not spin-down the disk (disk plates
> rotating, but device is removed from system), I reopen the bug because of
> this.
>
> 2. for USB-flashes
> There is no 'Safely remove drive' option in Nautilus for my USB-flashes.
> After 'Eject' the parent device remains in system and may be powered-off by
> gnome-disks. For me it's a good compromise between udisks1 and udisks2
> behavior.
>
>
> I'm ready to test and collect logs of my WD USB-HDD. I can't understand why
> Seagate drive unmounts all partitions before power-off, but WD does not.
> What logs can help you to understand the problem?

When the system is running with the WD USB-HDD, please include the output of 'gvfs-mount -li' from a non-root shell in a terminal in the desktop session.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-03:

#17

Download full text (5.4 KiB)

Thank you for reply, David!

>I have an idea of what's wrong here but before I speculate on that, what exactly does "enable automount" mean? Are you referring to having the 'auto' option in the /etc/fstab file?

By "enable automount" I mean these dconf-editor parameters: org.gnome.desktop.media-handling.automount and org.gnome.desktop.media-handling.automount-open (see comment #5). So if I set both parameters to true (in dconf-editor) I get all two partitions of my drive mounted in Nautilus on device connection.

>When the system is running with the WD USB-HDD, please include the output of 'gvfs-mount -li' from a non-root shell in a terminal in the desktop session.

The output of 'gvfs-mount -li' for my WD USB-HDD is as follows:
Drive(3): WD My Passport 0743
   Type: GProxyDrive (GProxyVolumeMonitorUDisks2)
   ids:
    unix-device: '/dev/sdc'
   themed icons: [drive-harddisk-usb] [drive-harddisk] [drive]
   symbolic themed icons: [drive-harddisk-usb-symbolic] [drive-harddisk-symbolic] [drive-symbolic] [drive-harddisk-usb] [drive-harddisk] [drive]
   is_media_removable=0
   has_media=1
   is_media_check_automatic=1
   can_poll_for_media=0
   can_eject=0
   can_start=0
   can_stop=1
   start_stop_type=shutdown
   sort_key=01hotplug/1391451089446989
   Volume(0): WD_2TB_NTFS
     Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
     ids:
      class: 'device'
      unix-device: '/dev/sdc2'
      uuid: '32BA1ADB5E526052'
      label: 'WD_2TB_NTFS'
     themed icons: [drive-harddisk-usb] [drive-harddisk] [drive]
     symbolic themed icons: [drive-harddisk-usb-symbolic] [drive-harddisk-symbolic] [drive-symbolic] [drive-harddisk-usb] [drive-harddisk] [drive]
     can_mount=1
     can_eject=0
     should_automount=1
     sort_key=gvfs.time_detected_usec.1391451089661368
   Volume(1): WD_2TB_EXT4
     Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
     ids:
      class: 'device'
      unix-device: '/dev/sdc1'
      uuid: '6d296a81-e054-4e09-a092-cee6a0041e0c'
      label: 'WD_2TB_EXT4'
     themed icons: [drive-harddisk-usb] [drive-harddisk] [drive]
     symbolic themed icons: [drive-harddisk-usb-symbolic] [drive-harddisk-symbolic] [drive-symbolic] [drive-harddisk-usb] [drive-harddisk] [drive]
     can_mount=1
     can_eject=0
     should_automount=1
     sort_key=gvfs.time_detected_usec.1391451089662205
     Mount(0): WD_2TB_EXT4 -> file:///run/media/flash/WD_2TB_EXT4
       Type: GProxyMount (GProxyVolumeMonitorUDisks2)
       default_location=file:///run/media/flash/WD_2TB_EXT4
       themed icons: [drive-harddisk-usb] [drive-harddisk] [drive]
       symbolic themed icons: [drive-harddisk-usb-symbolic] [drive-harddisk-symbolic] [drive-symbolic] [drive-harddisk-usb] [drive-harddisk] [drive]
       can_unmount=1
       can_eject=0
       is_shadowed=0
       sort_key=gvfs.time_detected_usec.1391451089941622

For my Seagate HDD I have:

Drive(3): ST950042 0AS
   Type: GProxyDrive (GProxyVolumeMonitorUDisks2)
   ids:
    unix-device: '/dev/sdc'
   themed icons: [drive-harddisk-usb] [drive-harddisk] [drive]
   symbolic themed icons: [drive-harddisk-usb-symbolic] [drive-harddisk-symbolic] [drive-symbolic] [d...

Thank you for reply, David!

>I have an idea of what's wrong here but before I speculate on that, what exactly does "enable automount" mean? Are you referring to having the 'auto' option in the /etc/fstab file?

By "enable automount" I mean these dconf-editor parameters: org.gnome.desktop.media-handling.automount and org.gnome.desktop.media-handling.automount-open (see comment #5). So if I set both parameters to true (in dconf-editor) I get all two partitions of my drive mounted in Nautilus on device connection.

>When the system is running with the WD USB-HDD, please include the output of 'gvfs-mount -li' from a non-root shell in a terminal in the desktop session.

The output of 'gvfs-mount -li' for my WD USB-HDD is as follows:
	Drive(3): WD My Passport 0743
	  Type: GProxyDrive (GProxyVolumeMonitorUDisks2)
	  ids:
	   unix-device: '/dev/sdc'
	  themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	  symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	  is_media_removable=0
	  has_media=1
	  is_media_check_automatic=1
	  can_poll_for_media=0
	  can_eject=0
	  can_start=0
	  can_stop=1
	  start_stop_type=shutdown
	  sort_key=01hotplug/1391451089446989
	  Volume(0): WD_2TB_NTFS
	    Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
	    ids:
	     class: 'device'
	     unix-device: '/dev/sdc2'
	     uuid: '32BA1ADB5E526052'
	     label: 'WD_2TB_NTFS'
	    themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    can_mount=1
	    can_eject=0
	    should_automount=1
	    sort_key=gvfs.time_detected_usec.1391451089661368
	  Volume(1): WD_2TB_EXT4
	    Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
	    ids:
	     class: 'device'
	     unix-device: '/dev/sdc1'
	     uuid: '6d296a81-e054-4e09-a092-cee6a0041e0c'
	     label: 'WD_2TB_EXT4'
	    themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    can_mount=1
	    can_eject=0
	    should_automount=1
	    sort_key=gvfs.time_detected_usec.1391451089662205
	    Mount(0): WD_2TB_EXT4 -> file:///run/media/flash/WD_2TB_EXT4
	      Type: GProxyMount (GProxyVolumeMonitorUDisks2)
	      default_location=file:///run/media/flash/WD_2TB_EXT4
	      themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	      symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	      can_unmount=1
	      can_eject=0
	      is_shadowed=0
	      sort_key=gvfs.time_detected_usec.1391451089941622

For my Seagate HDD I have:

Drive(3): ST950042 0AS
	  Type: GProxyDrive (GProxyVolumeMonitorUDisks2)
	  ids:
	   unix-device: '/dev/sdc'
	  themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	  symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	  is_media_removable=0
	  has_media=1
	  is_media_check_automatic=1
	  can_poll_for_media=0
	  can_eject=0
	  can_start=0
	  can_stop=1
	  start_stop_type=shutdown
	  sort_key=01hotplug/1391451261668976
	  Volume(0): NTFS
	    Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
	    ids:
	     class: 'device'
	     unix-device: '/dev/sdc2'
	     uuid: '5F6174ED0C58C4B3'
	     label: 'NTFS'
	    themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    can_mount=1
	    can_eject=0
	    should_automount=1
	    sort_key=gvfs.time_detected_usec.1391451261990760
	    Mount(0): NTFS -> file:///run/media/flash/NTFS
	      Type: GProxyMount (GProxyVolumeMonitorUDisks2)
	      default_location=file:///run/media/flash/NTFS
	      themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	      symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	      can_unmount=1
	      can_eject=0
	      is_shadowed=0
	      sort_key=gvfs.time_detected_usec.1391451263178059
	  Volume(1): GENTOO
	    Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
	    ids:
	     class: 'device'
	     unix-device: '/dev/sdc1'
	     uuid: '52e2b7ea-21e0-4973-aeae-f5b7edfadf40'
	     label: 'GENTOO'
	    themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	    can_mount=1
	    can_eject=0
	    should_automount=1
	    sort_key=gvfs.time_detected_usec.1391451261992313
	    Mount(0): GENTOO -> file:///run/media/flash/GENTOO
	      Type: GProxyMount (GProxyVolumeMonitorUDisks2)
	      default_location=file:///run/media/flash/GENTOO
	      themed icons:  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	      symbolic themed icons:  [drive-harddisk-usb-symbolic]  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk-usb]  [drive-harddisk]  [drive]
	      can_unmount=1
	      can_eject=0
	      is_shadowed=0
	      sort_key=gvfs.time_detected_usec.1391451262121538

I hope this help you to understand the problem.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-02-03:

#18

(Hmm, the drives have

can_stop=1
start_stop_type=shutdown

so everything should be good. My guess is that it's the NTFS partition that is the culprit. Specifically, unmounting it via udisks somehow fails.)

If you manually unmount the partitions, does powering down the drive work? Specifically, try this

1. Unmount all partitions using Disks
- if that fails, try 'umount /dev/sdXN' from a terminal. Does that work?
2. Press the "Power off" button in Disks when everything has been unmounted.

Does that work?

Also, please include all messages from udisks from syslog (e.g. /var/log/messages or similar) when pressing the "Power off" button in Disks. It should contain some useful info.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-04:

#19

Today I tested 5 other drives with different paritioning schemes (1 primary + 1 extended partition with some logical partitions in it):
3 of them were successfully Safely removed (in Nautilus) and Powered off (in Disks),
2 of them were successfully Safely removed (in Nautilus) and Powered off (in Disks) only after manual unmount.

>If you manually unmount the partitions, does powering down the drive work?
>Specifically, try this
>
> 1. Unmount all partitions using Disks
> - if that fails, try 'umount /dev/sdXN' from a terminal. Does that work?
did it in Disks with my WD drive

> 2. Press the "Power off" button in Disks when everything has been unmounted.
did it in Disks - my WD drive is spinned down.

>Does that work?
So it works.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-04:

#20

Created attachment 93407
Syslog/Message for my WD USB-HDD (from plugging-in to Safely remove) - Ubuntu 14.04 with UDisks 2.1.3

>Also, please include all messages from udisks from syslog (e.g. /var/log/messages or similar) when pressing the "Power off" button in Disks. It should contain some useful info.

I attached full log-file for my WD USB-HDD. It contains device plugging-in, detection by automount feature, un-mounting both partiotion in Disks, Powering off in Disks, device plugging-out as you recommended.

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-04:

#21

Created attachment 93414
Syslog/Message for my WD USB-HDD (from plugging-in to Safely remove) - Ubuntu 12.04 with UDisks 1.0.4-5ubuntu2.1

If that can help I prepared syslog/messages for my WD-HDD in Ubuntu 12.04 too. Sequence is identical to comment 15.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-02-04:

#22

Let me see if I understand this correctly:

1. Manually unmount, then power-off via the Disks GUI works as expected.
2. The "safely remove drive" button in Nautilus does not work as expected.

Is that about right?

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-04:

#23

It seems that my english is not perfect. I'm sorry.

Let's consider only WD-HDD.

>Let me see if I understand this correctly:
> 1. Manually unmount, then power-off via the Disks GUI works as expected.
Yes.
> 2. The "safely remove drive" button in Nautilus does not work as expected.
No. It works as expected on other drives, but not WD.
>Is that about right?
Yes and no.

Safely remove (in Nautilus) and Power off (in Disks) works as expected only if I manually unmount all WD partitions before Safe removal / Power off.

If I unmount all WD partitions manually and then do Safe removal / Power off HDD spins down.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-02-04:

#24

OK, I'm interested in output of /var/log/messages when it doesn't work with the WD. Or is that what you posted in comment 15?

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-04:

#25

>OK, I'm interested in output of /var/log/messages when it doesn't work with the WD. Or is that what you posted in comment 15?
I tested it again - the log in comment 15 represent both situations - when drive spinned-down and when it does not. Only timestamps differ, messages order is the same.

With udisks1 this WD-HDD spins-down (by Safely remove in Nautilus or Power off in Disks) even if all partitions mounted, with udisks2 it does not.
There is a little difference between udisks1 and udisks2 "powering off drive" algorithms. What other log-file can I attach to help you to understand the problem?

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-02-05:

#26

(In reply to comment #20)
> >OK, I'm interested in output of /var/log/messages when it doesn't work with the WD. Or is that what you posted in comment 15?
> I tested it again - the log in comment 15 represent both situations - when
> drive spinned-down and when it does not. Only timestamps differ, messages
> order is the same.
>
>
> With udisks1 this WD-HDD spins-down (by Safely remove in Nautilus or Power
> off in Disks) even if all partitions mounted, with udisks2 it does not.
> There is a little difference between udisks1 and udisks2 "powering off
> drive" algorithms. What other log-file can I attach to help you to
> understand the problem?

Your testing with udisks1 is on an older version of Ubuntu (12.04 vs. 14.04) isn't it? If so, any chance you can install the udisks1 package on the same OS as you tested with udisks2? The packages are parallel-installable (and called 'udisks' and 'udisks2') so it should be as simple as 'apt-get install udisks' and then run "udisks --detach /dev/sdX".

I'm asking for this because I think this is due to a kernel and/or ntfs-3g problem.

Another thing to try would be to see if it happens if the filesystem type is *not* ntfs, e.g. try with ext4. (I realize this may not be possible as you may not want to reformat the disk.)

To recap, the only difference now from udisks1 is that udisks2 does not send SYNCHRONIZE CACHE before START STOP UNIT (it didn't work on any of my devices when I make the recent udisks2 changes). If it turns out that udisks1 works as expected on 14.04, I will try to add this change to see if it makes the difference...

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-05:

#27

Created attachment 93492
log-files for my WD-HDD (Ubuntu 14.04 with udisks1 and udisks2)

Thank you for reply, David.

>Your testing with udisks1 is on an older version of Ubuntu (12.04 vs. 14.04) isn't it? If so, any chance you can install the udisks1 package on the same OS as you tested with udisks2? The packages are parallel-installable (and called 'udisks' and 'udisks2') so it should be as simple as 'apt-get install udisks' and then run "udisks --detach /dev/sdX".
I have already installed udisks1 (1.0.4-8ubuntu1) on Ubuntu 14.04 and it works as expected on all my drives if I unmount all partitions manually (from console, Nautilus or Disks - it does not matter).

>I'm asking for this because I think this is due to a kernel and/or ntfs-3g problem.
For me it seems that we have timing/race issue in udisks2.

>Another thing to try would be to see if it happens if the filesystem type is *not* ntfs, e.g. try with ext4. (I realize this may not be possible as you may not want to reformat the disk.)
I have 500Gb of data on my NTFS partition, so I do not want to reformat my HDD. I'm sorry for this.

>To recap, the only difference now from udisks1 is that udisks2 does not send SYNCHRONIZE CACHE before START STOP UNIT (it didn't work on any of my devices when I make the recent udisks2 changes). If it turns out that udisks1 works as expected on 14.04, I will try to add this change to see if it makes the difference...
If there are no other differences - please add SYNCHRONIZE CACHE, I'm ready to do a test and report back.

I prepared an archive of log-files for my WD-HDD on Ubuntu 14.04 with udisks1 and udisks2 installed.
The log-files are: "tailf /var/log/syslog", "gvfs-mount -o", "udisksctl monitor", "udisks --monitor-detail".
The test-cases are:
1. udisks2 Safely remove from Disks (mounted) = FAIL - not spinned down
    connect, auto-mount by Nautilus, clicked Power off in Disks, disconnect
2. udisks2 Safely remove from Disks (unmounted) = SUCCESS - spinned down
    connect auto-mount by Nautilus, unmount in Nautilus, clicked Safely remove drive in Nautilus, disconnect
3. udisks2 Safely remove from Nautilus (mounted) FAIL - not spinned down
    connect, auto-mount by Nautilus, clicked Safely remove drive in Nautilus, disconnect
4. udisks2 Safely remove from Nautilus (unmounted) = SUCCESS - spinned down
    connect, auto-mount by Nautilus, unmount in Nautilus, clicked Safely remove drive in Nautilus, disconnect
5. udisks --detach Safely remove (unmounted) = SUCCESS - spinned down
    connect, auto-mount by Nautilus, unmount in Nautilus, sent "udisks --detach /dev/sdX" in console, disconnect

On FAIL-cases there are interesting lines in "udisks --monitor-detail"
(udisks:2365): udisks-WARNING **: Couldn't call GetAll() to get properties for /org/freedesktop/UDisks/devices/sdc2: Method "GetAll" with signature "s" on interface "org.freedesktop.DBus.Properties" doesn't exist
may be it cause problems. I do not know.

I'm ready to test your new commits.

Created attachment 93492
log-files for my WD-HDD (Ubuntu 14.04 with udisks1 and udisks2)

Thank you for reply, David.

>Your testing with udisks1 is on an older version of Ubuntu (12.04 vs. 14.04) isn't it? If so, any chance you can install the udisks1 package on the same OS as you tested with udisks2? The packages are parallel-installable (and called 'udisks' and 'udisks2') so it should be as simple as 'apt-get install udisks' and then run "udisks --detach /dev/sdX".
I have already installed udisks1 (1.0.4-8ubuntu1) on Ubuntu 14.04 and it works as expected on all my drives if I unmount all partitions manually (from console, Nautilus or Disks - it does not matter).

>I'm asking for this because I think this is due to a kernel and/or ntfs-3g problem.
For me it seems that we have timing/race issue in udisks2.

>Another thing to try would be to see if it happens if the filesystem type is *not* ntfs, e.g. try with ext4. (I realize this may not be possible as you may not want to reformat the disk.)
I have 500Gb of data on my NTFS partition, so I do not want to reformat my HDD. I'm sorry for this.

>To recap, the only difference now from udisks1 is that udisks2 does not send SYNCHRONIZE CACHE before START STOP UNIT (it didn't work on any of my devices when I make the recent udisks2 changes). If it turns out that udisks1 works as expected on 14.04, I will try to add this change to see if it makes the difference...
If there are no other differences - please add SYNCHRONIZE CACHE, I'm ready to do a test and report back.

I prepared an archive of log-files for my WD-HDD on Ubuntu 14.04 with udisks1 and udisks2 installed.
The log-files are: "tailf /var/log/syslog", "gvfs-mount -o", "udisksctl monitor", "udisks --monitor-detail".
The test-cases are:
1. udisks2 Safely remove from Disks (mounted) = FAIL - not spinned down
    connect, auto-mount by Nautilus, clicked Power off in Disks, disconnect
2. udisks2 Safely remove from Disks (unmounted) = SUCCESS - spinned down
    connect auto-mount by Nautilus, unmount in Nautilus, clicked Safely remove drive in Nautilus, disconnect
3. udisks2 Safely remove from Nautilus (mounted) FAIL - not spinned down
    connect, auto-mount by Nautilus, clicked Safely remove drive in Nautilus, disconnect
4. udisks2 Safely remove from Nautilus (unmounted) =  SUCCESS - spinned down
    connect, auto-mount by Nautilus, unmount in Nautilus, clicked Safely remove drive in Nautilus, disconnect
5. udisks --detach Safely remove (unmounted) = SUCCESS - spinned down
    connect, auto-mount by Nautilus, unmount in Nautilus, sent "udisks --detach /dev/sdX" in console, disconnect

On FAIL-cases there are interesting lines in "udisks --monitor-detail"
    (udisks:2365): udisks-WARNING **: Couldn't call GetAll() to get properties for /org/freedesktop/UDisks/devices/sdc2: Method "GetAll" with signature "s" on interface "org.freedesktop.DBus.Properties" doesn't exist
may be it cause problems. I do not know.
  
I'm ready to test your new commits.

Revision history for this message

In freedesktop.org Bugzilla #71802, Zeuthen (zeuthen) wrote on 2014-02-05:

#28

(In reply to comment #22)
> I have 500Gb of data on my NTFS partition, so I do not want to reformat my
> HDD. I'm sorry for this.

Fair enough. I'll try to see if I can repro on my hardware.

> If there are no other differences - please add SYNCHRONIZE CACHE, I'm ready
> to do a test and report back.

Will do - thanks for testing!

> I prepared an archive of log-files for my WD-HDD on Ubuntu 14.04 with
> udisks1 and udisks2 installed.

Thanks for doing that - it's very helpful!

> On FAIL-cases there are interesting lines in "udisks --monitor-detail"
> (udisks:2365): udisks-WARNING **: Couldn't call GetAll() to get
> properties for /org/freedesktop/UDisks/devices/sdc2: Method "GetAll" with
> signature "s" on interface "org.freedesktop.DBus.Properties" doesn't exist
> may be it cause problems. I do not know.

This is likely not a problem.

Revision history for this message

In freedesktop.org Bugzilla #71802, programmist11180 (programmer11180) wrote on 2014-02-06:

#29

When I try execute (udisks2 installed):

$ udisksctl power-off -b /dev/sde

It says: "Unknown command `power-off'"

What do I do not so?

Revision history for this message

In freedesktop.org Bugzilla #71802, Norbert (nrbrtx) wrote on 2014-02-06:

#30

Hello, Programmist11180!
From comment #8 to #23 we talk about unrelease udisks2 version from git-repository.

If you are on Ubuntu (or Mint, or other Debian/Ubuntu based distro) you can follow my instruction (in comment #10) to compile udisks2 from latest sources and test "udisksctl power-off -b /dev/sde" again.

I have compiled deb-package for 14.04 i686 - I can post it here if you have any problems with compilation.

Revision history for this message

In freedesktop.org Bugzilla #71802, programmist11180 (programmer11180) wrote on 2014-02-08:

#31

Hello nrbrtx.
I have compiled and installed udisks 2.1.3. And I have a problem. udisksctl not work.

$ udisksctl power-off -b /dev/sde

(process:3807): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:3807): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed