Devstack does not deal well will quantum lowercase section names

Bug #1194064 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Gary Kotton
neutron
Fix Released
Low
ZhiQiang Fan
oslo-incubator
Won't Fix
Undecided
Unassigned
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34177

Changed in devstack:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Revision history for this message
Mark McLoughlin (markmc) wrote :

Ok, we've dug into this bug in some detail and the summary is that if you have a file with:

  [database]
  connection = sqlite:///...

  [database]
  sql_connection = mysql:///...

then the value returned by cfg will be the 'sqlite:///' value

This is arguably a bug in cfg and is seen in https://gist.github.com/markmc/5858373 ... basically the behaviour with t1.conf is not what you might expect. However, after some discussion we think is fairly reasonable behaviour and I'm going to mark it as WontFix in oslo.

Now, there is something we can do to help the situation in quantum - if we have the default values commented out everywhere, then even if the user supplies a value using the deprecated name it won't be overwritten by a default value using the new name

i.e. we would have:

  [database]
  #connection = sqlite:///...

  [database]
  sql_connection = mysql:///...

So, I'm opening a task against quantum to comment out default values

Changed in oslo:
status: New → Triaged
status: Triaged → Won't Fix
Changed in quantum:
importance: Undecided → Low
tags: added: quantum-core
Revision history for this message
Dean Troyer (dtroyer) wrote :

Is this going to be an upgrade issue? I'm hoping Mark's suggestion about commenting out defaults will handle that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/34177
Committed: http://github.com/openstack-dev/devstack/commit/d42634ff631e5faa5e3a91f581c861e59279e6f7
Submitter: Jenkins
Branch: master

commit d42634ff631e5faa5e3a91f581c861e59279e6f7
Author: Gary Kotton <email address hidden>
Date: Mon Jun 24 09:26:55 2013 +0000

    Use lowercase section names in Neutron (aka Quantum)

    Fixes bug 1194064

    The DEFAULT section remains the same.

    In addition to this the sql_connection has been changed to
    connection - this is for OSLO DB support.

    Change-Id: I56175146941a9cae966033b557e44097e29a5d43

Changed in devstack:
status: In Progress → Fix Released
Mate Lakat (mate-lakat)
description: updated
Revision history for this message
Mate Lakat (mate-lakat) wrote :

Added permalinks

tags: added: neutron-core
removed: quantum-core
Changed in neutron:
status: New → Triaged
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40164

Changed in neutron:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/40164
Committed: http://github.com/openstack/neutron/commit/3313448f2de1ce288944af101a794d706fd43abb
Submitter: Jenkins
Branch: master

commit 3313448f2de1ce288944af101a794d706fd43abb
Author: ZhiQiang Fan <email address hidden>
Date: Mon Jul 29 18:40:46 2013 +0800

    Avoid overwrite value of deprecated name in conf.

    See bug/1194064 #2 Mark McLoughlin's comment

    Fixes: Bug #1194064

    Change-Id: I421d2decfa8829796fe7b6c14f954f3cccc17215

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → havana-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.