there are key errors when using nova cells

Bug #1193233 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Yaguang Tang

Bug Description

in nova/cells/scheduler.py there are typo that caused key errors .

172
173 def _build_instances(self, message, target_cells, instance_uuids,
174 build_inst_kwargs):
175 """Attempt to build instance(s) or send msg to child cell."""
176 ctxt = message.ctxt
177 instance_properties = build_inst_kwargs['instances'][0]
178 instance_type = build_inst_kwargs['instance_type']
179 image = build_inst_kwargs['image']
180 security_groups = build_inst_kwargs['security_group']
181 block_device_mapping = build_inst_kwargs['block_device_mapping']
182
183 LOG.debug(_("Building instances with routing_path=%(routing_path)s"),
184 {'routing_path': message.routing_path})
185

instance_type not in build_inst_kwargs dict.
security_groups should be get from build_inst_kwargs['security_groups']

the key error exception can cause schedule to child cell failed.

Tags: cells
Yaguang Tang (heut2008)
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
description: updated
tags: added: cells
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/33928

Changed in nova:
status: New → In Progress
Yaguang Tang (heut2008)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/33928
Committed: http://github.com/openstack/nova/commit/a42adb28c9817b96178617bba9c42dac18bfec24
Submitter: Jenkins
Branch: master

commit a42adb28c9817b96178617bba9c42dac18bfec24
Author: Yaguang Tang <email address hidden>
Date: Fri Jun 21 14:40:37 2013 +0800

    Fix KeyError exception when scheduling to child cell.

    Fix typo 'security_group' and update related unit tests.

    Fix bug #1193233

    Change-Id: I6d92759b0d7e2ce81c2065a4eada35c559ccbcd7

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.