Currently, KombuStubs is defined this way:
class KombuStubs:
@staticmethod
def setUp(self):
if kombu:
self.config(fake_rabbit=True)
self.config(rpc_response_timeout=5)
self.rpc = impl_kombu
self.addCleanup(impl_kombu.cleanup)
else:
self.rpc = None
@staticmethod and usage of self variable is misleading and ugly. The original intention was to use this class as a fixture in various test cases. The problem is that this fixture requires a way to override config options for a test, which is done by config() method of test case instances. In order to use it, KombuStubs must have a reference to a test case instance.
We'd better pass this reference to KombuStubs __init__() method, rather than use a static method.
Fix proposed to branch: master
Review: https:/