Need prep all instance['metadata'] access for objects

[Chris Behrens]

  File "/home/cbehrens/git/nova/openstack.git/nova/api/openstack/compute/views/servers.py", line 136, in <genexpr>
    return dict((item['key'], item['value']) for item in metadata)

We need to normalize all instance['metadata'] to dicts and switch code to work with them... much like we had/have to do for system_metadata.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/33623

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/33935

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/33623
Committed: http://github.com/openstack/nova/commit/8596f8b294e552873a29b6861bae4aa794d92b31
Submitter: Jenkins
Branch: master

commit 8596f8b294e552873a29b6861bae4aa794d92b31
Author: Alexei Kornienko <email address hidden>
Date: Wed Jun 19 12:37:57 2013 +0300

    Fix metadata access in prep for instance objects

    Related to blueprint unified-object-model
    Fixes: bug #1192012

    Change-Id: I8b708dc3d89fedfcb4bbf5d26b959da1298b0525