HAL : macbook-backlight is broken for Macbook C2D

[Movi]

The fdi policy in HAL is wrong fo Macbook Core 2 Duo - which is MacBook2,1. The fdi only matches against Macbook1,1

the line taken from /usr/share/hal/fdi/policy/10osvendor/10-macbook-backlight.fdi

  <match key="smbios.system.product" string="MacBook1,1">

for Core2Duo it should be
  <match key="smbios.system.product" string="MacBook2,1">.

I don't really have an understanding of XML, but the match key should include both models. Anyways, changing this bit enables backlight control for me (A Core2Duo Macbook).

[pveith (patrick-veith)]

Apple changed its name from "Apple Computers, Inc" to just "Apple Inc." this makes the two fdi for newer macbook devices unusable in feisty.

Relevant files:
/usr/share/hal/fdi/policy/10osvendor/10-macbook-backlight.fdi
/usr/share/hal/fdi/policy/10osvendor/10-macbookpro-utils.fdi

Fix for the adventeres:
Change in line 6 of /usr/share/hal/fdi/policy/10osvendor/10-macbook-backlight.fdi "Apple Comupter, Inc" to "Apple Inc.".

Change in line 8 of /usr/share/hal/fdi/policy/10osvendor/10-macbookpro-utils.fdi "Apple Comupter, Inc" to "Apple Inc.".

That fixed the bug for me....

[Johannes Hölzl (johannes-hoelzl)]

Apple changed his smbios.system.manufacturer string for newer MacBooks
from "Apple Computers, Inc." to "Apple Inc.". So the file
"fdi/policy/10osvendor/10-macbook-backlight.fdi" needs to add this new
name to its matching key.

[Danny Kukawka (danny-kukawka)]

Created an attachment (id=10467)
Patch to fix the reported issue

Could you check if this patch help? I would propose we should check for 'Apple' and ' Inc.' in the fdi-file instead of double the matches.

[Johannes Hölzl (johannes-hoelzl)]

Tried the attached patch with hal 0.5.8.1 under Ubuntu. (Sorry couldn't get the git version to run properly :-( )

The matching for "Apple" and " Inc." works! Thanks!

[Henrique Ferreiro (henrique-ferreiro)]

Support for 2nd generation MacBooks is included in newer hal and the Apple Inc. rename is posted as freedesktop bug 11351

[Danny Kukawka (danny-kukawka)]

fixed in git trunk

[Fabio Massimo Di Nitto (fabbione)]

hal (0.5.9.1-1ubuntu6) gutsy; urgency=low

  * debian/patches/macbook-backlight.diff: Add backlight support to new
    MacBook and MacBookPro.
    Upstream commits:
    a88fc4ff5e21668d4c41fa5bc7d2188791250b7a
    68eb19a7cf5e31203bf7d1c8728e61afc74975bb
  (Closes LP: #119184)

 -- <email address hidden> (Fabio M. Di Nitto) Wed, 05 Sep 2007 05:52:20 +0200

[CTAF (goctaf)]

the bug is not corrected for me with the 0.5.9.1-1. on macbook core 2 duo.

It worked under feisty if I doesnt use the hal package from backport.

[CTAF (goctaf)]

dont know why, but now it work again under gutsy without changing anything, sorry for the flood

[Loe Spee (lgespee)]

I installed Ubuntu 7.10 (Gutsy Gibbon) beta on my C2D MacBook and the screen backlighting control works out of the box (I did try it after downloading all updates up until 2007-09-30).
The only difference between Mac OS X and Ubuntu now is that the lowest lighting setting in Mac OS X really turns off the LCD backlighting whereas in Ubuntu it's not turned off just has a very low setting.

[Stefano Rivera (stefanor)]

Feisty is EOL