PowerVM driver needs to implement get_host_uptime

Bug #1191785 reported by Matt Riedemann
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Matt Riedemann

Bug Description

This tempest gate test is failing in havana when the PowerVM driver is being used:

https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_hypervisor.py#L88

That's because the get_host_uptime method on ComputeDriver isn't implemented in the PowerVM driver.

Tags: powervm
Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
status: New → In Progress
Revision history for this message
Matt Riedemann (mriedem) wrote :

Also needs to be backported to grizzly because the tests in tempest were also backported to grizzly:

https://github.com/openstack/tempest/commit/c9692fb66c1c66a627c1a4e47c27be7c109bede6

tags: added: grizzly-backport-potential
Revision history for this message
ChangBo Guo(gcb) (glongwave) wrote :

Matt, I add commet in your code review . I also looked at the libvirt implements for this fuction , it doesn't parse the output .
Any way , I will cancel my code review .
$ sysstat -short padmin
  09:58PM up 159 days, 17:29, 7 users, load average: 1.86, 1.93, 1.29
$ oem_setup_env
# uptime
  09:58PM up 159 days, 17:29, 7 users, load average: 1.73, 1.90, 1.29

Revision history for this message
Matt Riedemann (mriedem) wrote :

ChangBo, I couldn't find anything in the VIOS/IVM infocenter on an 'uptime' command. I found this on oem_setup_env:

http://pic.dhe.ibm.com/infocenter/powersys/v3r1m5/index.jsp?topic=/iphcg/oem_setup_env.htm

Sounds like that's for just installing and working with vendor devices and shouldn't be used for VIOS administration.

Revision history for this message
ChangBo Guo(gcb) (glongwave) wrote :

Matt , agree with that ,we'd better use command documented .
But in fact we have some codes in powervm driver using 'oem_stup_env'.
 All the method with suffix "command_as_root" use command first oem_setup_env firstly ,then run as root.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/33171
Committed: http://github.com/openstack/nova/commit/0946017e289cc865913980dbe199106d9b152cf3
Submitter: Jenkins
Branch: master

commit 0946017e289cc865913980dbe199106d9b152cf3
Author: Matt Riedemann <email address hidden>
Date: Sat Jun 15 13:10:26 2013 -0700

    Implement get_host_uptime for powervm driver

    This patch implements the get_host_uptime method for the powervm driver
    by calling the sysstat command on the backing hypervisor and returning
    the parsed results.

    Fixes bug 1191785

    Change-Id: I67aaf6a5f5eb6b3a411ca9a0284d9a3016dd2947

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/35159

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.