port-update with multiple IP addr fails with PostgreSQL

Bug #1191653 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Hua Zhang

Bug Description

port-update with multiple IP address fails when the db backend is PostgreSQL.

$ quantum port-update baa71064-05bf-4cd3-a27c-2390c1c64c2b --fixed_ips type=dict list=true subnet_id=8c03107e-1efa-48c7-a7f7-55485179d159,ip_address=10.0.0.3 subnet_id=8c03107e-1efa-48c7-a7f7-55485179d159,ip_address=10.0.0.4
Request Failed: internal server error while processing your request.

The output of quantum-server is http://paste.openstack.org/show/38757/

- Ubuntu 12.04 LTS with PostgreSQL
- /etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini
sql_connection = postgresql://root:stackdb@localhost/ovs_quantum?client_encoding=utf8

Tags: db
Akihiro Motoki (amotoki)
description: updated
Akihiro Motoki (amotoki)
tags: added: db
Hua Zhang (zhhuabj)
Changed in neutron:
assignee: nobody → Hua Zhang (zhhuabj)
Revision history for this message
Hua Zhang (zhhuabj) wrote :

I don't know why the code review link doesn't be updated here automatically after I have submitted the code,
this is the link, https://review.openstack.org/#/c/36426/
thanks.

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/36426
Committed: http://github.com/openstack/neutron/commit/b9900c2334abf5e4b1ad09ee24ed88184c085349
Submitter: Jenkins
Branch: master

commit b9900c2334abf5e4b1ad09ee24ed88184c085349
Author: zhhuabj <email address hidden>
Date: Wed Jul 10 17:49:01 2013 +0800

    port-update fails when using SELECT FOR UPDATE lock

    In Postgresql, it will throw the bellow exception when
    using SELECT FOR UPDATE lock combined with outer join.
    "SELECT FOR UPDATE/SHARE cannot be applied to the
     nullable side of an outer join"

    The reason can refer http://www.postgresql.org/ \
    <email address hidden>

    for this issue, I don't think outer join is necessary,
    so I change it to use inner join.

    Fixes bug #1191653

    Change-Id: Ifc9ecad91324ce28399431ea77fe0865b6d8e523

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → havana-3
Changed in neutron:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.