libvirt resizes of instances with ephemeral or swap defined fail

Bug #1191608 reported by Rafi Khardalian
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Rafi Khardalian

Bug Description

Using the current master tree, attempting to resize an instance with the libvirt driver, which has an ephemeral or swap disk will throw an exception. This is a result of my commit:

https://github.com/openstack/nova/commit/6e768363450774cfee90e41aa5c40af780d3e04a

The code was not properly guarding against backing files not existing with QCOW2 images. As such, get_disk_backing_file() would return None, then the subsequent call to basename() on None would cause an exception.

Revision history for this message
Rafi Khardalian (rkhardalian) wrote :

Patch is ready.

Changed in nova:
assignee: nobody → Rafi Khardalian (rkhardalian)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/33007
Committed: http://github.com/openstack/nova/commit/cf3cf3c8e5137e775eec9939e88aa1df339ba1bf
Submitter: Jenkins
Branch: master

commit cf3cf3c8e5137e775eec9939e88aa1df339ba1bf
Author: Rafi Khardalian <email address hidden>
Date: Fri Jun 14 06:47:57 2013 +0000

    libvirt fix resize/migrates with swap or ephemeral

    Fixes bug 1191608

    The code was not properly guarding against backing files not
    existing with QCOW2 images. As such, get_disk_backing_file() would
    return None, then the subsequent call to basename() on None would
    cause an exception.

    This bug was introduced with the fix for bug 1185588 and commit
    6e768363.

    Change-Id: I4b1237ddf01b9398bfdc141180260136b36cae5a

Changed in nova:
status: In Progress → Fix Committed
tags: added: grizzly-backport-potential
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.