Port window not updated ("Cancel the expedition" starts a new one)
Bug #1191556 reported by
wl-zocker
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Medium
|
Unassigned |
Bug Description
After having started an expedition and the wares are being delivered, cancelling the expedition will cancel it (as expected).
But if you keep the port window open and wait until the ship has arrived (the wares from the port will disappear), the button still reads "Cancel the expedition". However, when you click on it, another expedition will start. (Tested in r6581. Take care of bug 1191554 when trying to reproduce this one.)
Would it be able to update the window of the port when the expedition has started?
Related branches
lp:~widelands-dev/widelands/bug-1191556-cancel-expedition
- Klaus Halfmann: Approve
- TiborB: Approve
-
Diff: 211 lines (+75/-27)7 files modifiedsrc/economy/expedition_bootstrap.cc (+3/-1)
src/economy/expedition_bootstrap.h (+11/-0)
src/notifications/note_ids.h (+1/-1)
src/ui_basic/tabpanel.cc (+13/-1)
src/ui_basic/tabpanel.h (+3/-0)
src/wui/buildingwindow.cc (+35/-24)
src/wui/buildingwindow.h (+9/-0)
Changed in widelands: | |
assignee: | nobody → Nasenbaer (nasenbaer) |
milestone: | none → build18-rc1 |
Changed in widelands: | |
assignee: | Nasenbaer (nasenbaer) → nobody |
Changed in widelands: | |
status: | Confirmed → In Progress |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
agreed in all points :)