Improve unit test coverage for Cisco plugin model code

Bug #1190620 reported by Henry Gessau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Dane LeBlanc

Bug Description

Improve unit test coverage for ...

quantum/plugins/cisco/models/virt_phy_sw_v2 193 34 0 31 5 78%

Tags: unittest cisco
Changed in quantum:
importance: Undecided → Wishlist
status: New → Triaged
ZhiQiang Fan (aji-zqfan)
tags: added: unittest
Dane LeBlanc (leblancd)
Changed in neutron:
assignee: nobody → Dane LeBlanc (leblancd)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58125

Changed in neutron:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/58125
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b6a8aea4d1fe8be6073af57fad2ab6863d8f359c
Submitter: Jenkins
Branch: master

commit b6a8aea4d1fe8be6073af57fad2ab6863d8f359c
Author: Dane LeBlanc <email address hidden>
Date: Thu Nov 21 12:34:57 2013 -0500

    Improve unit test coverage for Cisco plugin model code

    Closes-Bug: #1190620

    This fix improves unit test coverage for:
    quantum/plugins/cisco/models/virt_phy_sw_v2.py
    Test coverage is improved from about 78% to 99%.

    One change included in this fix is removal of some code in
    the _invoke_plugin() method in virt_phy_sw_v2.py which looks
    like it's attempting to handle the case where the number of
    arguments being passed to _invoke_plugin() exceeds the number
    of arguments expected for the target plugin method. This
    section of code does not get executed for any existing
    calls to _invoke_plugin(), and it doesn't appear that
    this logic would work (except when the target plugin method
    includes a **kwargs expansion).

    Change-Id: Ibceb7a462a213f3ba693bcbe94e77d97b2e1440a

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.