storage-node.pp fails to pass swift zone in puppet 3.x

[Simon Sellar]

The following code uses $swift_zone instead of $zone from the definition.

This causes an empty string to be used in puppet 3, probably due to new variable scoping.

  define device_endpoint ($swift_local_net_ip, $zone, $weight) {
    @@ring_object_device { "${swift_local_net_ip}:6000/${name}":
      zone => $swift_zone,
      weight => $weight,
    }
    @@ring_container_device { "${swift_local_net_ip}:6001/${name}":
      zone => $swift_zone,
      weight => $weight,
    }
    @@ring_account_device { "${swift_local_net_ip}:6002/${name}":
      zone => $swift_zone,
      weight => $weight,
    }
  }

I have a patch ready to submit that works

[Simon Sellar (simon-sellar-o)]

Please ignore the patch at comment 1, I have now submitted to https://review.openstack.org/#/c/32996/

No rspec available as exported resources don't seem to be able to be checked.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32996
Committed: http://github.com/stackforge/puppet-openstack/commit/296679e6abfb91277bc7ab7aa3ebe310d605e228
Submitter: Jenkins
Branch: master

commit 296679e6abfb91277bc7ab7aa3ebe310d605e228
Author: Simon Sellar <email address hidden>
Date: Fri Jun 14 14:52:39 2013 +0930

    Storage node now uses local zone variable name.

    Puppet 3 scoping changes mean that the exported resources cannot see
    the parent scope $swift_zone variable, and must instead use the $zone
    variable passed to the device_endpoint defined type.

    Change-Id: I9780065c535da713c6d1d4a156f5d688e0ab9c63
    Fixes: bug #1190459