nova bare metal helper: local variable 'root_uuid' referenced before assignment

[Dan Prince]

When trying to deploy bare metal instances I'm hitting the following error:

2013-06-12 01:31:25,263.263 6890 ERROR nova.virt.baremetal.deploy_helper [req-556bf535-7ddd-4c5b-8bbe-2ee3cde8aa69 None None] deployment to node 3 failed
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper Traceback (most recent call last):
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper File "/opt/stack/venvs/nova/local/lib/python2.7/site-packages/nova/cmd/baremetal_deploy_helper.py", line 242, in run
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper deploy(**params)
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper File "/opt/stack/venvs/nova/local/lib/python2.7/site-packages/nova/cmd/baremetal_deploy_helper.py", line 211, in deploy
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper switch_pxe_config(pxe_config_path, root_uuid)
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper UnboundLocalError: local variable 'root_uuid' referenced before assignment
2013-06-12 01:31:25,263.263 6890 TRACE nova.virt.baremetal.deploy_helper

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/32745

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/32747

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32745
Committed: http://github.com/openstack/nova/commit/30bc1ef250f0230a9a1f562cd51b0f57d4a35912
Submitter: Jenkins
Branch: master

commit 30bc1ef250f0230a9a1f562cd51b0f57d4a35912
Author: Dan Prince <email address hidden>
Date: Wed Jun 12 11:31:57 2013 -0400

    Fix local variable 'root_uuid' ref before assign

    Fixes an issue where the root_uuid variable gets used
    before it is assigned.

    This moves the switch_pxe_config function so that it only gets
    called if root_uuid is assigned.

    Fixes LP Bug #1190269.

    Change-Id: I1abaf391f3a80dcacc815d2e38c6da9ad1b099ff

[aeva black (tenbrae)]

Also addressed by: https://review.openstack.org/#/c/32823

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/33882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/33882
Committed: http://github.com/openstack/ironic/commit/fb17b2cadd24c0ff33b2bf1788934d3d4b8cd89c
Submitter: Jenkins
Branch: master

commit fb17b2cadd24c0ff33b2bf1788934d3d4b8cd89c
Author: Devananda van der Veen <email address hidden>
Date: Thu Jun 20 13:42:12 2013 -0700

    Port from nova: Fix local variable 'root_uuid' ref

    Port I0221984ce4f7c406990315ef820d9ce63fc6e015 from Nova.

    Fixes an issue where the root_uuid variable gets used
    before it is assigned.

    Instead of generating NameError, log a more descriptive error
    and allow the exception to be raised.

    Fixes LP Bug #1190269.

    Change-Id: Icecac7443d296546734f7a13995530a7991b9f04