Redundant architecture property update in powervm snapshot

[Matt Riedemann]

This is essentially the same issue as was reported in bug 1176173 but that was for the libvirt driver, this one is for the powervm driver:

https://github.com/openstack/nova/blob/master/nova/virt/powervm/driver.py#L164

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/32596

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32596
Committed: http://github.com/openstack/nova/commit/50680eee2f9842eaca5491e740f1715a2bd32f90
Submitter: Jenkins
Branch: master

commit 50680eee2f9842eaca5491e740f1715a2bd32f90
Author: Matt Riedemann <email address hidden>
Date: Tue Jun 11 10:32:39 2013 -0700

    Remove redundant architecture property update in powervm snapshot

    During an instance snapshot if the architecture property is defined
    in the image it is updated twice in the snapshot image.
    The snapshot is created with the metadata values from the
    "instance_system_metadata" table and then, if defined, the architecture
    property is updated from the value in the base image in that moment.

    There is no reason to treat this property differently from others.
    Also, it didn't respect the "non_inheritable_image_properties" option.

    This change removes the special behavior for the architecture property
    in the powervm driver during a snapshot.

    Fixes bug 1189969

    Change-Id: I05ebcaef7b75387827917b5b223868794d98e0aa