Ubuntu
python-secretstorage package

Should run tests during build

Bug #1189172 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-secretstorage (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

python-secretstorage has tests but they aren't being run during the build. They should be!

From MIR bug 1188935:
"Unfortunately the test suite can't be run at the moment, because GNOME Keyring (the only actually working Secret Service implementation) refuses to run in xvfb. As an alternative, one can mock a Secret Service server using python-dbusmock, but this is a non-trivial task."

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

There is some Secret Service mocking in libsecret tests (https://git.gnome.org/browse/libsecret/tree/libsecret/tests) (these are also not run in Ubuntu), probably we can use that.

Changed in python-secretstorage (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-secretstorage - 2.0.0-1ubuntu1

---------------
python-secretstorage (2.0.0-1ubuntu1) trusty; urgency=medium

  * debian/patches/use_any_collection.diff: Use get_any_collection()
    where possible.
  * Add autopkgtests (LP: #1189172).
 -- Dmitry Shachnev <email address hidden> Wed, 29 Jan 2014 20:21:01 +0400

Changed in python-secretstorage (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I understand that DEP-8 tests are different from build-time tests, but they are not worse!

See the today's discussion on ubuntu-devel for a reason why I don't run them build-time.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.