Logic bug in nfs_share selection
Bug #1188877 reported by
Morgan Fainberg
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Cinder |
Fix Released
|
Undecided
|
Morgan Fainberg | ||
Bug Description
There is a minor logic bug (comparison against the wrong values) in the NFS volume driver. Right now the oversubscription ratio checks against "actual used space" when looking to see if there is enough space on the share for the new volume.
The check should be against total_allocated instead of total_available.
The net impact is a one-time event that would allow a volume allocation to select a share and exceed the oversubscription ratio.
| Changed in cinder: | |
| assignee: | nobody → Morgan Fainberg (mdrnstm) |
| Changed in cinder: | |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to cinder (master) | #1 |
| Changed in cinder: | |
| status: | In Progress → Fix Committed |
| Changed in cinder: | |
| milestone: | none → havana-2 |
| status: | Fix Committed → Fix Released |
| Changed in cinder: | |
| milestone: | havana-2 → 2013.2 |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit 4ecfcc3b1749484
Author: Morgan Fainberg <email address hidden>
Date: Fri Jun 7 17:18:59 2013 -0700
Minor Logic bug in NFS Driver.
When checking oversubscription rate, we need to ensure that we
check the _allocated_ (apparant size) not the _available_ (actual
usage) on the NFS share. This fix ensures we are now checking the
correct values. This bug allowed (effectively) a one-time
volume allocation that would push the "apparant" size over the
oversubscri
Change-Id: I189b689cb76ac2
Fixes: bug #1188877