returning the wrong error types for CFN API exceptions

Bug #1188473 reported by Liang Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Liang Chen

Bug Description

Please see comment from Zane on https://review.openstack.org/#/c/31756/3

Revision history for this message
Steven Hardy (shardy) wrote :

I'm confused, why have we got a bug report about a bug which hasn't been merged yet?

Seems like you just need to fix up the patch in the review above to align with one of the existing CFN exception/error types?

Revision history for this message
Zane Bitter (zaneb) wrote :

The bug is that existing ones are wrong too. e.g. StackExists should return AlreadyExists, not InvalidParameterValue.

Liang Chen (cbjchen)
Changed in heat:
assignee: nobody → Liang Chen (cbjchen)
Steven Hardy (shardy)
Changed in heat:
milestone: none → havana-2
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/32723

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/32723
Committed: http://github.com/openstack/heat/commit/7b9c2312cd323c0cfc80f86c0385ff2c9f8e5daf
Submitter: Jenkins
Branch: master

commit 7b9c2312cd323c0cfc80f86c0385ff2c9f8e5daf
Author: Liang Chen <email address hidden>
Date: Wed Jun 12 21:47:05 2013 +0800

    fix an CFN API and AWS error mapping

    StackExists should return AlreadyExists, not InvalidParameterValue

    Fixes bug #1188473

    Change-Id: Ia969cddc1b61caa13f4f70bcc29f3160595a779b

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.