Potential typo in /ubiquity/scripts/install.py

[Nathan Collins]

Binary package hint: ubiquity

In the method mount_source() the code

            misc.execute('mount', '-t', 'unionfs', '-o',
                         'dirs=' + map(lambda x: '%s=ro' % x, self.mountpoints),
                         'unionfs', self.source)

occurs at lines 684-686 (in the 1.5.1 source I downloaded). I think the middle line doesn't make sense, apparently concatenating a string with a list of strings, and that you probably meant

                          'dirs=' + ':'.join(map(lambda x: '%s=ro' % x, self.mountpoints)),

instead. I think you want to join() on ':' since the unionfs man page says colon is the separator for directories in the dirs option.

Sorry if I'm wasting your time. I was reading the install.py code while waiting for the installer to finish (yeah, I was kind of bored :) ) and I noticed that line that doesn't seem to make sense. I didn't actually observe an error.

[Siegfried Gevatter (rainct)]

I have no idea if this is a bug or it's correct, but for the case it is here is a patch.

[Colin Watson (cjwatson)]

RainCT, there's no need to spend time attaching a patch when the report already describes the exact change that needs to be made. :-) Thanks for the thought, but it wasn't necessary.

Nathan, good catch; applied. It's just as well we don't use that code yet ...

[Evan (ev)]

ubiquity (1.5.4) gutsy; urgency=low

  [ Colin Watson ]
  * Make sure that the bounds of the spin button in the partition edit
    dialog always include the current size of the partition, even if for
    some reason it is outside the minimum/maximum resize ranges reported by
    partman, which can happen due to rounding errors in ubiquity/partman
    communication (part of #95619).
  * Save /var/log/casper.log to installed system (LP: #119993).
  * KDE frontend:
    - Say "Skip" (or translation thereof) rather than "Cancel" in progress
      dialog (LP: #116631).
    - Fix crash if one of the placeholder continent entries is selected as
      the timezone (LP: #112813).
  * From the department of pickiness: PEP-8 import ordering.
  * Move .glade and .ui files to a new top-level gui directory in the source
    package. Install .ui files in /usr/share/ubiquity/qt rather than in
    /usr/lib/ubiquity/ubiquity/frontend now that they are loaded on the fly
    rather than being compiled into .py files statically.
  * If /etc/udev/rules.d/70-persistent-net.rules exists, copy it rather than
    generating /etc/iftab.

  [ Mario Limonciello ]
  * Break up the glade file into multiple pieces to make updates
    to single pages a lot easier.

  [ Nathan Collins ]
  * Fix typo in unionfs dirs= option generation (LP: #118742).

  [ Evan Dandrea ]
  * Work around 122141 by keeping a reference to the button image.
  * Automatic update of included source packages: silo-installer
    1.10ubuntu3.

 -- Evan Dandrea <email address hidden> Tue, 26 Jun 2007 10:26:53 -0400