instance dict is being abused to pass config_drive_id to libvirt on build

[Chris Behrens]

compute/api create() shoves 'config_drive_id' into instance properties... which get passed down during a build.. but that's not a column in the DB.

It looks like it actually makes it all the way into libvirt because we don't use the results from any instance_update() in between, which is bad because the instance we pass has old task_state, etc.

Also: This will not work when we switch to passing objects.

---

Additionally it appears that all code related to supporting image ids with config drive was supposed to be removed anyway: https://bugs.launchpad.net/nova/+bug/1029647

[Chris Behrens (cbehrens)]

sigh. click too fast on status and you get undesired results. heh.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/31314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/31314
Committed: http://github.com/openstack/nova/commit/b013d80ff7ffa75a823f246445a07cb6970d321e
Submitter: Jenkins
Branch: master

commit b013d80ff7ffa75a823f246445a07cb6970d321e
Author: Chris Behrens <email address hidden>
Date: Fri May 31 23:13:23 2013 +0000

    Remove broken config_drive image_href support.

    image_href support has not been working since at least shortly before
    Folsom release. This is a good indication that this functionality is not
    used. As far as I can tell, the docs also do not match what was
    supported. An image ID was required, but docs show examples with full
    hrefs.

    DocImpact

    http://docs.openstack.org/developer/nova/api_ext/ext_config_drive.html

    References to supporting image_hrefs should be removed.

    This patch also removes the hack that passed a config_drive_id via
    the Instance dictionary when config_drive_id is not a valid Column for
    Instance.

    Fixes bug 1186401

    Change-Id: Iced7bc8e278cb9f208183f1dbb7a293675a47eae