Pecan logging config duplicates oslo logging config

Bug #1184941 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Mark McLoughlin
Grizzly
Fix Released
Medium
Eoghan Glynn
Ironic
Fix Released
Medium
Mark McLoughlin

Bug Description

Playing with Ironic, I was confused to see duplicate log entries and I also see them in Ceilometer:

  $> ceilometer-api --debug
  ...
  2013-05-28 08:10:46,535 DEBUG [ceilometer.storage][MainThread] looking for 'sqlite' driver in 'ceilometer.storage'
  2013-05-28 08:10:46 DEBUG [ceilometer.storage] looking for 'sqlite' driver in 'ceilometer.storage'
  2013-05-28 08:10:46,540 INFO [ceilometer.storage.impl_sqlalchemy][MainThread] connecting to sqlite:////ceilometer/openstack/common/db/ceilometer.sqlite
  2013-05-28 08:10:46 INFO [ceilometer.storage.impl_sqlalchemy] connecting to sqlite:////ceilometer/openstack/common/db/ceilometer.sqlite

The issue here is that we're using pecan to configure logging for the 'ceilometer' and 'ironic' loggers, even though we use oslo logging to configure the root logger

Removing the pecan logging configuration completely fixes the issue for me and, conceptually, I don't see why we need both ... oslo logging configuration should do everything we need?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30697

Changed in ironic:
assignee: nobody → Mark McLoughlin (markmc)
status: New → In Progress
Revision history for this message
Mark McLoughlin (markmc) wrote :
Changed in ceilometer:
assignee: nobody → Mark McLoughlin (markmc)
importance: Undecided → Medium
Changed in ironic:
importance: Undecided → Medium
Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/30695
Committed: http://github.com/openstack/ceilometer/commit/e6a083fc5acb6f3ad03cc1df0943e4e746629128
Submitter: Jenkins
Branch: master

commit e6a083fc5acb6f3ad03cc1df0943e4e746629128
Author: Mark McLoughlin <email address hidden>
Date: Tue May 28 11:18:13 2013 +0100

    Don't use pecan to configure logging

    Fixes bug #1184941

    openstack.common.log gives a mechanism to configure logging and, by
    default, we will set up a handler on root logger. Using pecan to also
    configure a handler on the 'ironic' logger means every log message gets
    logged to console twice.

    It seems that the pecan logging configuration stuff is redundant with
    our existing logging configuration infrastructure.

    Change-Id: Iec0630b0e842e3b6a90021bf552d9b857c5a0552

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → havana-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/30697
Committed: http://github.com/openstack/ironic/commit/46b9a88ba110e5489749327f6dd381a8af695c3e
Submitter: Jenkins
Branch: master

commit 46b9a88ba110e5489749327f6dd381a8af695c3e
Author: Mark McLoughlin <email address hidden>
Date: Mon May 27 19:42:57 2013 +0100

    Don't use pecan to configure logging

    Fixes bug #1184941

    openstack.common.log gives a mechanism to configure logging and, by
    default, we will set up a handler on root logger. Using pecan to also
    configure a handler on the 'ironic' logger means every log message gets
    logged to console twice.

    It seems that the pecan logging configuration stuff is redundant with
    our existing logging configuration infrastructure.

    Change-Id: Iec0630b0e842e3b6a90021bf552d9b857c5a0552

Changed in ironic:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/31196

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/grizzly)

Reviewed: https://review.openstack.org/31196
Committed: http://github.com/openstack/ceilometer/commit/ff94b0e6ed99469fec6830b0fb5c0aa3ee667195
Submitter: Jenkins
Branch: stable/grizzly

commit ff94b0e6ed99469fec6830b0fb5c0aa3ee667195
Author: Mark McLoughlin <email address hidden>
Date: Tue May 28 11:18:13 2013 +0100

    Don't use pecan to configure logging

    Fixes bug #1184941

    openstack.common.log gives a mechanism to configure logging and, by
    default, we will set up a handler on root logger. Using pecan to also
    configure a handler on the 'ironic' logger means every log message gets
    logged to console twice.

    It seems that the pecan logging configuration stuff is redundant with
    our existing logging configuration infrastructure.

    Change-Id: Iec0630b0e842e3b6a90021bf552d9b857c5a0552
    (cherry picked from commit e6a083fc5acb6f3ad03cc1df0943e4e746629128)

tags: added: in-stable-grizzly
Revision history for this message
Eoghan Glynn (eglynn) wrote :
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-1 → 2013.2
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.