cannot handle "=" in parameters

Bug #1183842 reported by Steven Hardy
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
High
Sulochan Acharya

Bug Description

Fail with "too many values to unpack" error in the following situation, which works fine via heat-cfn

# heat create os5 --template-file=/home/shardy/git/heat-templates/openshift-origin/OpenShift.template --parameters="KeyName=${USER}_key;DnsSecKey=hsgx1m31PbamNF4WEcHlwjIlCGgifOdoB58/wwC7a4oAONQ/fDV5ctqrYBoLlKHhTfkyQEw9iVScKYZbbMtMNg==;UpstreamDNS=8.8.8.8"
too many values to unpack

# heat-cfn create os5 --template-file=/home/shardy/git/heat-templates/openshift-origin/OpenShift.template --parameters="KeyName=${USER}_key;DnsSecKey=hsgx1m31PbamNF4WEcHlwjIlCGgifOdoB58/wwC7a4oAONQ/fDV5ctqrYBoLlKHhTfkyQEw9iVScKYZbbMtMNg==;UpstreamDNS=8.8.8.8"
<CreateStackResponse>
  <CreateStackResult>
    <StackId>arn:openstack:heat::1938f0707fe04b58b0053040d4a0fe06:stacks/os5/b9df3a3c-042d-4afb-92c7-7a57b84b382a</StackId>
  </CreateStackResult>
</CreateStackResponse>

Changed in python-heatclient:
assignee: nobody → Sulochan Acharya (sulochan-acharya)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30966

Changed in python-heatclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/30966
Committed: http://github.com/openstack/python-heatclient/commit/9b1ce2108189cdfd499e116500fad566670260bc
Submitter: Jenkins
Branch: master

commit 9b1ce2108189cdfd499e116500fad566670260bc
Author: Sulochan Acharya <email address hidden>
Date: Wed May 29 18:04:46 2013 -0500

    Fixes text split for parameters

    Make text split only on the first "=" element, this will
    allow for values to have multiple "=" in the string.
    Also, ensure that key = value pair is honored in parameters,
    exit otherwise with error message. Tests included.
    Fixes bug #1183842

    Change-Id: Ic8897405c61dee49f5927b53f055b0d0686eea7d

Changed in python-heatclient:
status: In Progress → Fix Committed
Changed in python-heatclient:
importance: Undecided → High
milestone: none → v0.2.3
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.