Optimize SecurityGroupsOutputController

Bug #1182730 reported by Aaron Rosen
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Aaron Rosen

Bug Description

When doing nova show currently SecurityGroupsOutputController calls out to quantum to list all the security groups and ports owned by a given tenant when we could directly query by device_id to find the security groups on an instance.

Tags: network
Aaron Rosen (arosen)
Changed in nova:
assignee: nobody → Aaron Rosen (arosen)
Michael Still (mikal)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30048

Changed in nova:
status: Confirmed → In Progress
Aaron Rosen (arosen)
tags: added: network
Revision history for this message
Aaron Rosen (arosen) wrote :

Hi, i think this should be backported to grizzly as "nova show instance" is having nova-api query all the ports for a given tenant rather than just the ones that match the instance id.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/30048
Committed: http://github.com/openstack/nova/commit/0604e77654d0c7eb5fda9600e9ca604da656d856
Submitter: Jenkins
Branch: master

commit 0604e77654d0c7eb5fda9600e9ca604da656d856
Author: Aaron Rosen <email address hidden>
Date: Tue May 21 21:18:29 2013 -0700

    Optimize SecurityGroupsOutputController by len(servers)

    The following patch adds an optimization for _extend_servers() so that
    it calls get_instance_security_groups() when len(servers) == 1, and
    get_instances_security_groups_bindings() when > 1. In addition, this patch
    adds a return statement if not len(servers) as there is no reason to
    perform a query if there are no servers.

    Fixes bug 1182730

    Change-Id: I149bf32176d60e72d76576168d15995f7215b657

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Aaron Rosen (arosen)
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/35164

Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.