Nicira plugin: gateway ports waste IP addresses

[Salvatore Orlando]

The nicira 'net-gateway' extension has a facility for connecting network to 'L2 gateway' services.
This connection creates a port on a quantum network. Regardless of whether subnets are configured or not on this network, a gateway port should have no ips.

This is currently enforced here:
https://github.com/openstack/quantum/blob/master/quantum/plugins/nicira/nicira_networkgw_db.py#L317

However the code merely removes the IP allocation.
The IP addresses don't go back in the pool, and are therefore not recycled.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/29974

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/29974
Committed: http://github.com/openstack/quantum/commit/8b3445eaa5008d3f8c9932ab95a03d0115b6ea32
Submitter: Jenkins
Branch: master

commit 8b3445eaa5008d3f8c9932ab95a03d0115b6ea32
Author: Salvatore Orlando <email address hidden>
Date: Tue May 21 20:05:00 2013 +0200

    Recycle IPs used by 'gateway' ports

    Bug 1182602

    Previous code simply removed IP allocation for these ports which
    should never have an IP. This patch triggers IP recycling so the
    IP addresses can be reused by other ports.

    Change-Id: I594e02d5bbc78b219eab07e595cde713d6450ffe