NetApp: iSCSI drivers' reserved percentage is 100

Bug #1182015 reported by Rushi Agrawal
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Navneet
Grizzly
Fix Released
Low
Navneet

Bug Description

3 out of 4 drivers in cinder/volume/drivers/netapp/iscsi.py have reserved_percentage as 100, instead of 0, in reported-capabilities. The driver still works fine as the scheduler doesnt check the actual percentage in case the available space is 'infinite' or 'unknown'.

Also, need to change the capacities from 'infinite' to 'unknown'

Revision history for this message
Alexander Gordeev (a-gordeev) wrote :

according to
https://github.com/openstack/cinder/blob/master/cinder/scheduler/filters/capacity_filter.py#L48

if the percentage is 100 then the cinder scheduler will fail at volume creation just because 1.0 - 1 equals 0

Revision history for this message
Navneet (singn) wrote :

we will keep capacity to infinite till we implement real capability. Will fix reserved percentage.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/33974

Changed in cinder:
assignee: nobody → Navneet (singn)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/33974
Committed: http://github.com/openstack/cinder/commit/5a8ead7d154bbbb60b3272044a86fddea7afd929
Submitter: Jenkins
Branch: master

commit 5a8ead7d154bbbb60b3272044a86fddea7afd929
Author: Navneet Singh <email address hidden>
Date: Fri Jun 21 18:46:36 2013 +0530

    NetApp:iSCSI drivers reserved percent need to change to 0.

    The iscsi drivers reserved percent is 100 as of now. This needs
    to be changed to 0 for default values. It needs to be corrected
    so that filter scheduler does not discard netapp backend.

    bug 1182015

    Change-Id: Id80584e5d478c83de97735706994206e024f8bf6

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-2
status: Fix Committed → Fix Released
tags: added: grizzly-backport-potential
Navneet (singn)
tags: added: navneet-netapp-backport
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/49487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/49679

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/grizzly)

Reviewed: https://review.openstack.org/49679
Committed: http://github.com/openstack/cinder/commit/d23c0889b89eafdd318301993da26cd390827cd4
Submitter: Jenkins
Branch: stable/grizzly

commit d23c0889b89eafdd318301993da26cd390827cd4
Author: Navneet Singh <email address hidden>
Date: Fri Jun 21 18:46:36 2013 +0530

    NetApp:iSCSI drivers reserved percent need to change to 0.

    The iscsi drivers reserved percent is 100 as of now. This needs
    to be changed to 0 for default values. It needs to be corrected
    so that filter scheduler does not discard netapp backend.

    bug 1182015

    Change-Id: Id80584e5d478c83de97735706994206e024f8bf6
    (cherry picked from commit 5a8ead7d154bbbb60b3272044a86fddea7afd929)

tags: added: in-stable-grizzly
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-2 → 2013.2
Alan Pevec (apevec)
Changed in cinder:
importance: Undecided → Low
tags: removed: grizzly-backport-potential in-stable-grizzly
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.