Incorrect logic in api.v2.base.Controller._is_visible

[Eugene Nikanorov]

The following code:

       try:
            attr = (attributes.RESOURCE_ATTRIBUTE_MAP
                    [self._collection].get(attr_name))
            if attr and attr.get('enforce_policy'):
                authz_check = policy.check_if_exists(
                    context, action, data)
        except KeyError:
            # The extension was not configured for adding its resources
            # to the global resource attribute map. Policy check should
            # not be performed
            LOG.debug(_("The resource %(resource)s was not found in the "
                        "RESOURCE_ATTRIBUTE_MAP; unable to perform authZ "
                        "check for attribute %(attr)s"),
                      {'resource': self._collection,
                       'attr': attr_name})

Will generate " UnboundLocalError: local variable 'attr' referenced before assignment " in case 'attr = ' throws KeyError

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/29704

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/29704
Committed: http://github.com/openstack/quantum/commit/60d478e518d63290f110177a31e8f5ffc1c54681
Submitter: Jenkins
Branch: master

commit 60d478e518d63290f110177a31e8f5ffc1c54681
Author: Eugene Nikanorov <email address hidden>
Date: Sun May 19 18:01:33 2013 +0400

    Fix logic in api.v2.base.Controller._is_visible

    Fix accessing yet unassigned local variable in case
    exception is thrown.

    fixes bug 1181718

    Change-Id: Iea8f0cc252c1d2105cc696d917a347aa10b206a8