Attributes of FakeBroker class changes while test execution

[Vladimir Vechkanov]

In unit tests for db_replicator there is FakeBroker class. We use it instead of db_replicator.brokerclass function. So instead of call brokerclass function while using test will be called init method for FakeBroker class. That's why while creating new instance of replicator we set replicator.brokerclass attribute as FakeBroker (not as instance of FakeBroker, but as class). For each test we create new instance of replicator, but in all of them .brokerclass is a link to FakeBroker

In one of the tests attribute of replicator.brokerclass is changing, so all tests which are called after that will be use not expected value of the FaleBroker attribute.

More than that, changed attribute caused calling qarantine_db function which deleting all "test/unit/common" directory. Tests in nosetests are calling in alphabetical order (not in order how they are written) so understanding why directory was deleted is too hard.

I suggest to create function which will give new FakeBroker class for each test case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/29228

[Samuel Merritt (torgomatic)]

Ah yes, the old mock leakage problem.

In past cases where I've noticed a leaked mock, I've found that changing from a manual mock installation to using 'mock.patch' as a context manager ensures the leak does not return. (Of course, this is just a suggestion. I haven't seen the code in question.)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/29228
Committed: http://github.com/openstack/swift/commit/fd3b64bb16df5617cdc429130e8325eeda6b45c6
Submitter: Jenkins
Branch: master

commit fd3b64bb16df5617cdc429130e8325eeda6b45c6
Author: Vladimir Vechkanov <email address hidden>
Date: Tue May 21 18:57:17 2013 +0400

    Fix problem with changing class attribute

    Attribute get_repl_missing_table in FakeBroker class was changed in
    test_replicate_object_quarantine function and not returned back. That's
    why next test cases takes not expexted values from FakeBroker.

    fixes bug 1180354
    Change-Id: Iba55255771e6483832c7782fcbe331e20e818f4e