Add negative test cases for subnet create/update for GW

[Paul Michali]

Although bug 1078490 is a config error, I noticed that there were a few negative test cases that were not exercised. This bug is to improve the coverage, by added these test cases.

Specifically, tests to check that GW IP is not network IP or BCAST IP, when force_gateway_on_subnet flag is set. Could (optionally) add a test that checks that GW IP is on subnet, when flag is set and doing a subnet update (although this does use the same validation logic).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/28816

[Paul Michali (pcm)]

Thanks for setting the importance and tags Mark.

Should it have a milestone set?

PCM (Paul Michali)

Contact info for Cisco users http://twiki.cisco.com/Main/pcm

On May 10, 2013, at 12:11 PM, Mark McClain wrote:

> ** Changed in: quantum
> Importance: Undecided => Medium
>
> ** Tags added: unittest
>
> ** Tags added: l3-ipam-dhcp
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1178675
>
> Title:
> Add negative test cases for subnet create/update for GW
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> Although bug 1078490 is a config error, I noticed that there were a
> few negative test cases that were not exercised. This bug is to
> improve the coverage, by added these test cases.
>
> Specifically, tests to check that GW IP is not network IP or BCAST IP,
> when force_gateway_on_subnet flag is set. Could (optionally) add a
> test that checks that GW IP is on subnet, when flag is set and doing a
> subnet update (although this does use the same validation logic).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1178675/+subscriptions

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28816
Committed: http://github.com/openstack/quantum/commit/c2a672fe2186be7d19f3c0eea5e60f8cfc29381d
Submitter: Jenkins
Branch: master

commit c2a672fe2186be7d19f3c0eea5e60f8cfc29381d
Author: Paul Michali <email address hidden>
Date: Fri May 10 06:17:24 2013 -0700

    Add negative UT cases for subnet/GW create/update

    When force_gateway_on_subnet is configured, ensure
    that a GW with IP same as subnet, and BCAST GW IP
    are rejected during subnet create. For subnet update,
    ensure GW outside of subnet is rejected.

    bug 1178675

    Change-Id: Ice58f7e1be7966b247c165e52807405401e5a4ea