No need to add "#!/usr/bin/env python" for all .py files under nova/cmd

Bug #1178543 reported by Guangya Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Guangya Liu (Jay Lau)

Bug Description

Now in Havana, all nova service script start up logic are moved to nova/cmd and those files are not simply python script but python files, so there is no need to still keep "#!/usr/bin/env python" for those files, since they won't be run directly as scripts.

Changed in nova:
assignee: nobody → Jay Lau (jay-lau-513)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/28776

Changed in nova:
status: New → In Progress
Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/28776
Committed: http://github.com/openstack/nova/commit/3f4b8dfc4b9f1b2d6347676be5b3814575c6b5b9
Submitter: Jenkins
Branch: master

commit 3f4b8dfc4b9f1b2d6347676be5b3814575c6b5b9
Author: Jay Lau <email address hidden>
Date: Fri May 10 15:03:45 2013 +0800

    Remove "#!/usr/bin/env python" from .py files under nova/cmd

    Fix bug 1178543

    Now in Havana, all nova service script start up logic are moved to
    nova/cmd and those files are not simply python script but python
    files, so there is no need to still keep "#!/usr/bin/env python"
    for those files since they won't be run directly as scripts.

    Change-Id: Ic102215dc0200ec1f6b47951bef31d58b08022ef

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.