default bootstack api's ratelimit at too low a rate

Bug #1178529 reported by Robert Collins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Joe Gordon
tripleo
Fix Released
High
Joe Gordon

Bug Description

Just registering 30 or so nodes with nova baremetal-node-create in a loop starts ratelimiting - and the nova client doesn't retry.

Revision history for this message
Robert Collins (lifeless) wrote :

e.g. in paste.ini

limits =(POST, "*", .*, 60, MINUTE);(POST, "*/servers", ^/servers, 50, DAY);(PUT, "*", .*, 10, MINUTE);(GET, "*changes-since*", .*changes-since.*, 3, MINUTE);(DELETE, "*", .*, 100, MINUTE)

Joe Gordon (jogo)
Changed in tripleo:
assignee: nobody → Joe Gordon (jogo)
Joe Gordon (jogo)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Joe Gordon (jogo) wrote :

I was unable to reproduce this.

I tried setting with and without limits being set as specified above. And ran several nova commands (such as nova list) in a fast loop, and could not get the API to ratelimit.

Changed in tripleo:
status: In Progress → Incomplete
Joe Gordon (jogo)
Changed in tripleo:
status: Incomplete → In Progress
Revision history for this message
Joe Gordon (jogo) wrote :

Here are the default rate limits

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/limits.py#L225

These values are still used when 'limits=' is used in paste.ini. So no template changes needed, currently working on getting the default values fixed upstream.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34774

Changed in nova:
assignee: nobody → Joe Gordon (jogo)
status: New → In Progress
Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/34774
Committed: http://github.com/openstack/nova/commit/827c2d30b858c525579dcd612e9cf4aa85259fa9
Submitter: Jenkins
Branch: master

commit 827c2d30b858c525579dcd612e9cf4aa85259fa9
Author: Joe Gordon <email address hidden>
Date: Thu Jun 27 10:49:50 2013 -0700

    Sane rest API rate limit defaults

    The previous rate limit defaults were unusable in any deployment.
    Rate limiting to 10 POSTS per minute and 50 servers per day seems
    to low, especially when we can use quotas to actually limit the amount
    of resources a user can consume.

    Update docstring to explain what the rate limiting is used for.

    Fixes bug 1178529

    DocImpact changed default values

    Change-Id: I8cc93423f76d9b0a5135adf69babc4ff355a0951

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Joe Gordon (jogo) wrote :

Fix committed to nova to bump up defaults, second patch pending to disable all together.

Changed in tripleo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Changed in tripleo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.