OpenStack Dashboard (Horizon)

'msgid' format string with unnamed arguments cannot be properly localized in dashboards/project/instances/workflows/create_instance.py

Bug #1177629 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki
OpenStack Dashboard (Horizon) 2013.2 "havana"
Grizzly
Fix Released
Low
Kieran Spear
OpenStack Dashboard (Horizon) 2013.1.3

Bug Description

After commit 84553ab5720719a64e4d46ffcb5704ba8b34234a, "../manage.py makemessages -a" produces the following error:

motoki@gemini:~/.../horizon/openstack_dashboard (master)$ ../manage.py makemessages -a
processing language hu
Error: errors happened while running xgettext on create_instance.py
./dashboards/project/instances/workflows/create_instance.py:115: warning: 'msgid' format string with unnamed arguments cannot be properly localized:
        The translator cannot reorder the arguments.
        Please consider using a format string with named arguments,
        and a mapping instead of a tuple for the arguments.

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/28495

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Kieran Spear (kspear)
Changed in horizon:
importance: Undecided → Low
milestone: none → havana-1
Akihiro Motoki (amotoki)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/28495
Committed: http://github.com/openstack/horizon/commit/58b0e62cab3b81898719881d4f8d16e094eb4854
Submitter: Jenkins
Branch: master

commit 58b0e62cab3b81898719881d4f8d16e094eb4854
Author: Akihiro MOTOKI <email address hidden>
Date: Wed May 8 11:37:19 2013 +0900

    Ensure to use keyword parameters in format string in create_instance.py

    Fixes bug #1177629

    Change-Id: If5a8b74bbcb698f2833ada275be914271dc1b995

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
Kieran Spear (kspear) wrote :

This also causes a volume with no display name to show the ol' <django.utils.functional.__proxy__> in place of the volume type label.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/36156

Adam Gandelman (gandelman-a)
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/grizzly)

Reviewed: https://review.openstack.org/36156
Committed: http://github.com/openstack/horizon/commit/ed3ff15a4ffcd730d3f0966c12c64ec8e392f47d
Submitter: Jenkins
Branch: stable/grizzly

commit ed3ff15a4ffcd730d3f0966c12c64ec8e392f47d
Author: Akihiro MOTOKI <email address hidden>
Date: Wed May 8 11:37:19 2013 +0900

    Ensure to use keyword parameters in format string in create_instance.py

    Fixes bug #1177629

    Change-Id: If5a8b74bbcb698f2833ada275be914271dc1b995
    (cherry picked from commit 58b0e62cab3b81898719881d4f8d16e094eb4854)

Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.