Ubuntu UI Toolkit

Toolbar actions buttons are not placed dynamically

Bug #1177123 reported by Nekhelesh Ramananthan on 2013-05-06

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Ubuntu UI Toolkit	Fix Released	High	Tim Peeters
	ubuntu-ui-toolkit (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

After the latest changes to the toolbar code, the toolbar action button are awkwardly placed in the toolbar.

To illustrate this, see Screenshot #1. You will notice that the buttons "Add Preset" and "Edit" are not flushed to the right. This is because there is another toolbar button "Delete" which is not visible. This can be seen in Screenshot #2.

Previously, the toolbar buttons always flushed to a corner when any toolbar button was not visible.

Related branches

lp:~tpeeters/ubuntu-ui-toolkit/toolbarItems

Merged into lp:ubuntu-ui-toolkit at revision 550

PS Jenkins bot: Approve (continuous-integration) on 2013-06-19

Tim Peeters: Needs Fixing on 2013-06-18

Gustavo Pichorim Boiko (community): Needs Fixing on 2013-06-18

lp:ubuntu/saucy-proposed/ubuntu-ui-toolkit

lp:ubuntu/saucy/ubuntu-ui-toolkit

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2013-05-06:

#1

Screenshot #1 Edit (4.2 KiB, image/png)

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2013-05-06:

#2

Screenshot #2 Edit (4.2 KiB, image/png)

Revision history for this message

Florian Boucault (fboucault) wrote on 2013-05-14:

#3

Which version of the toolkit are you testing with?

Changed in ubuntu-ui-toolkit:
assignee:	nobody → Tim Peeters (tpeeters)
importance:	Undecided → High

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2013-05-14:

#4

I currently still experience the issue with qtdeclarative5-ubuntu-ui-toolkit-plugin 0.1.46daily13.05.01ubuntu.unity.nextbzr484raring0. However it is difficult to find out at which version exactly the problem started appearing. Although if I recall, the moment the toolbar properties were deprecated, I started noticing the issue.

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-05-27:

#5

Could you please add a small/simple example qml program that demonstrates the bug?

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2013-06-03:

#6

Test.tar Edit (14.5 KiB, application/x-tar)

@Tim, sorry for the delay. I created an example project and added code to illustrate the problem. While executing the code, reveal the toolbar and then press the "Add Preset" button. The edit and delete button are hidden. However the "Add Preset" no longer dynamically shifts to the far right position making it look odd.

Tim Peeters (tpeeters) on 2013-06-14

Changed in ubuntu-ui-toolkit:
status:	New → In Progress

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-06-19:

#7

Fix committed into lp:ubuntu-ui-toolkit at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-06-20:

#8

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46daily13.06.20-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46daily13.06.20-0ubuntu1) saucy; urgency=low

  [ tpeeters ]
  * Replace ToolbarActions by ToolbarItems and use ActionItem as a
    visual representation of Actions. (LP: #1177123)

[ Ubuntu daily release ]
* Automatic snapshot from revision 550
-- Ubuntu daily release <email address hidden> Thu, 20 Jun 2013 04:01:27 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status:	New → Fix Released

Florian Boucault (fboucault) on 2013-07-03

Changed in ubuntu-ui-toolkit:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.