OpenStack Compute (nova)

Restarting compute service mistakenly reboots live instance

Bug #1176897 reported by Yufang Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Yufang Zhang
OpenStack Compute (nova) 2013.2 "havana"
Grizzly
Fix Released
Medium
Vish Ishaya
OpenStack Compute (nova) 2013.1.2

Bug Description

Occasionally, libvirt would get NOSTATE from hypervisor as instance state. Thus if we don't ignore instances in NOSTATE in resume_state_on_host_boot() method, we would mistakenly reboot such instances when we restart nova-compute service or on host boot.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/28301

Changed in nova:
assignee: nobody → Yufang Zhang (yufang521247)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/28301
Committed: http://github.com/openstack/nova/commit/0098f12e8b1f035c7ecdb952cfcd4bbae86b6246
Submitter: Jenkins
Branch: master

commit 0098f12e8b1f035c7ecdb952cfcd4bbae86b6246
Author: Yufang Zhang <email address hidden>
Date: Mon May 6 21:06:53 2013 +0800

    libvirt: ignore NOSTATE in resume_state_on_host_boot() method.

    Occasionally, libvirt would get NOSTATE from hypervisor as instance
    state. Thus if we don't ignore instances in NOSTATE in
    resume_state_on_host_boot() method, we would mistakenly reboot such
    instances when we restart nova-compute service or on host boot. This
    patch fixes this by adding NOSTATE into ignored_states.

    Bug 1176897

    Change-Id: I651cb043d7f97fde29b2a62e6ead8222062f01f7

Changed in nova:
status: In Progress → Fix Committed
Vish Ishaya (vishvananda)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28501

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/28501
Committed: http://github.com/openstack/nova/commit/1a682a5bc0b280b9075a1f640a8a6db971bcb05f
Submitter: Jenkins
Branch: stable/grizzly

commit 1a682a5bc0b280b9075a1f640a8a6db971bcb05f
Author: Yufang Zhang <email address hidden>
Date: Mon May 6 21:06:53 2013 +0800

    libvirt: ignore NOSTATE in resume_state_on_host_boot() method.

    Occasionally, libvirt would get NOSTATE from hypervisor as instance
    state. Thus if we don't ignore instances in NOSTATE in
    resume_state_on_host_boot() method, we would mistakenly reboot such
    instances when we restart nova-compute service or on host boot. This
    patch fixes this by adding NOSTATE into ignored_states.

    Bug 1176897

    Change-Id: I651cb043d7f97fde29b2a62e6ead8222062f01f7
    (cherry picked from commit 0098f12e8b1f035c7ecdb952cfcd4bbae86b6246)

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.