quantum-openvswitch-agent fails due to missing nicira plugin

[Matt Riedemann]

Running quantum havana from commit bde296d1040a6c1397faebf80f0ba164bed2c937 and configured with the openvswitch plugin, the quantum-openvswitch-agent fails to start with this error:

[root@rhel62 init.d]# /usr/bin/quantum-openvswitch-agent --config-file /etc/quantum/quantum.conf --config-file /etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini
 Traceback (most recent call last):
   File "/usr/bin/quantum-openvswitch-agent", line 22, in <module>
     from quantum.plugins.openvswitch.agent.ovs_quantum_agent import main
   File "/usr/lib/python2.6/site-packages/quantum/plugins/__init__.py", line 20, in <module>
     from quantum.plugins import nicira
 ImportError: cannot import name nicira

Looking at the code, it's introduced by this commit:

https://github.com/openstack/quantum/commit/0446eaccbf898c85b87810231bffb0651639f262

This code should only be executed if the plugin configured for quantum is nicira, this doesn't apply to openvswitch.

[Matt Riedemann (mriedem)]

Already got the patch so will just assign to myself.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/28097

[Armando Migliaccio (armando-migliaccio)]

Matt,

Can you tell a little more on your test environment, and how to repro?

I don't disagree with the fix, but I wonder how this one was missed by the gate job. I haven't been able to reproduce it, neither from sources nor from packages.

Thanks,
Armando

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28097
Committed: http://github.com/openstack/quantum/commit/a2bdb161a59c19b8c1a3ea3f5171219e62b214e0
Submitter: Jenkins
Branch: master

commit a2bdb161a59c19b8c1a3ea3f5171219e62b214e0
Author: Matt Riedemann <email address hidden>
Date: Wed May 1 04:05:07 2013 -0700

    Only map nicira_nvp_plugin module if installed

    When starting any quantum plugin agent service, only map the
    nicira_nvp_plugin module if nicira is installed and configured for
    quantum.

    fixes bug 1175750

    Change-Id: I7f2c40011363e2579d4c35716f5a7d413663a698

[Matt Riedemann (mriedem)]

Armando,

We're just installing grizzly on RHEL 6.3 and using the Quantum openvswitch plugin, so we install the openstack-quantum-openvswitch rpm which only lays down the python code for the ovs plugin, the nicira plugin code is not installed since we don't install the openstack-quantum-nicira plugin. Then when we start the quantum-openvswitch-agent service, it invokes quantum/plugins/__init__.py which tries to import the nicira module and that fails since we don't have openstack-quantum-nicira installed.

The openstack-quantum rpm packaging spec is here:

https://github.com/redhat-openstack/openstack-quantum/blob/master/openstack-quantum.spec

Our install scripts are essentially following this:

http://docs.openstack.org/grizzly/openstack-network/admin/content/fedora_q_agent.html

Matt

[Armando Migliaccio (armando-migliaccio)]

Matt,

Thanks for the clarification, now I understand why this wasn't caught up by the gate job and why I couldn't reproduce it :)